From 4f8d34faba5be84eb9f60b7fd360852586401263 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 21 Oct 2012 16:20:42 +0300 Subject: [PATCH] [PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error --- 8e/2e743be10906862d07385d4c19c7184a0b3647 | 80 +++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 8e/2e743be10906862d07385d4c19c7184a0b3647 diff --git a/8e/2e743be10906862d07385d4c19c7184a0b3647 b/8e/2e743be10906862d07385d4c19c7184a0b3647 new file mode 100644 index 000000000..a3f2706f1 --- /dev/null +++ b/8e/2e743be10906862d07385d4c19c7184a0b3647 @@ -0,0 +1,80 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 37F8B431FAF + for ; Sun, 21 Oct 2012 06:20:43 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id VtBVXSLvaXmn for ; + Sun, 21 Oct 2012 06:20:42 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id F0BBB431FAE + for ; Sun, 21 Oct 2012 06:20:41 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id D6345100372; Sun, 21 Oct 2012 16:20:44 +0300 (EEST) +From: Tomi Ollila +To: notmuch@notmuchmail.org +Subject: [PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error +Date: Sun, 21 Oct 2012 16:20:42 +0300 +Message-Id: <1350825642-11652-1-git-send-email-tomi.ollila@iki.fi> +X-Mailer: git-send-email 1.7.1 +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 21 Oct 2012 13:20:43 -0000 + +When inserting of email bodypart failes, insert a failure message +to the buffer (and continue) instead of halting the insertion of +the rest of that email thread in question. +--- + +This is alternative to + +id:"1350824336-11060-1-git-send-email-tomi.ollila@iki.fi" + +This adds error message string to the output, error message in +id:"87d31artti.fsf@inf-8657.int-evry.fr" is shown as + + !!! bodypart insert error: Wrong type argument: stringp, nil !!! + +See id:"1350824336-11060-1-git-send-email-tomi.ollila@iki.fi" +for more discussion. + + emacs/notmuch-show.el | 4 +++- + 1 files changed, 3 insertions(+), 1 deletions(-) + +diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +index f273eb4..651a5ee 100644 +--- a/emacs/notmuch-show.el ++++ b/emacs/notmuch-show.el +@@ -815,7 +815,9 @@ message at DEPTH in the current thread." + ;; Run the content handlers until one of them returns a non-nil + ;; value. + (while (and handlers +- (not (funcall (car handlers) msg part content-type nth depth declared-type))) ++ (not (condition-case nil ++ (funcall (car handlers) msg part content-type nth depth declared-type) ++ (error (progn (insert "!!! bodypart insert error !!!\n") nil))))) + (setq handlers (cdr handlers)))) + t) + +-- +1.7.1 + -- 2.26.2