From 4ef34a15a03d9e368139d06b95289490281c1883 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Thu, 23 Feb 2012 22:04:00 +0000 Subject: [PATCH] Re: [PATCH 1/2] emacs/cli: remove entire-thread default from show: JSON --- 69/57ee3862c66914996da5ebe7e524ce90dd72c5 | 103 ++++++++++++++++++++++ 1 file changed, 103 insertions(+) create mode 100644 69/57ee3862c66914996da5ebe7e524ce90dd72c5 diff --git a/69/57ee3862c66914996da5ebe7e524ce90dd72c5 b/69/57ee3862c66914996da5ebe7e524ce90dd72c5 new file mode 100644 index 000000000..e82f5a91d --- /dev/null +++ b/69/57ee3862c66914996da5ebe7e524ce90dd72c5 @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 884CA431FBC + for ; Thu, 23 Feb 2012 14:02:26 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RssgzJxGVHmP for ; + Thu, 23 Feb 2012 14:02:26 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 020A9431FAE + for ; Thu, 23 Feb 2012 14:02:25 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1S0gk1-0007S2-Q3; Thu, 23 Feb 2012 22:02:22 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1S0gk1-00058w-J0; Thu, 23 Feb 2012 22:02:21 +0000 +From: Mark Walters +To: Adam Wolfe Gordon +Subject: Re: [PATCH 1/2] emacs/cli: remove entire-thread default from show: + JSON +In-Reply-To: + +References: <1330033294-21980-1-git-send-email-markwalters1009@gmail.com> + <1330033294-21980-2-git-send-email-markwalters1009@gmail.com> + +User-Agent: Notmuch/0.11.1+216~gc56f296 (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Thu, 23 Feb 2012 22:04:00 +0000 +Message-ID: <877gzdxl4f.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 30c009ec24049c1252d252df5d04fb20 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 23 Feb 2012 22:02:26 -0000 + +On Thu, 23 Feb 2012 14:45:57 -0700, Adam Wolfe Gordon = +wrote: +> Hi Mark, +>=20 +> On Thu, Feb 23, 2012 at 14:41, Mark Walters w= +rote: +> > Previously notmuch-show.c defaulted to --entire-thread when +> > format=3Djson. =C2=A0Make the default just the matching messages, but m= +ake +> > the single emacs caller add --entire-thread to the arguments supplied +> > so the end result should be unchanged. +>=20 +> The patch looks good to me. You should probably update the man page as +> well, to reflect the change in defauls. + +Thanks for the review. I will include an updated man page in the next +version. + +Many thanks + +Mark + -- 2.26.2