From 4dccbb3fdfec4b190845050e08f0806a13f6da31 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 6 Nov 2012 22:16:36 +2000 Subject: [PATCH] Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes --- 39/078c7ba8245b275f75de3f52263115a21fce3f | 82 +++++++++++++++++++++++ 1 file changed, 82 insertions(+) create mode 100644 39/078c7ba8245b275f75de3f52263115a21fce3f diff --git a/39/078c7ba8245b275f75de3f52263115a21fce3f b/39/078c7ba8245b275f75de3f52263115a21fce3f new file mode 100644 index 000000000..c39914208 --- /dev/null +++ b/39/078c7ba8245b275f75de3f52263115a21fce3f @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id F1EA6431FB6 + for ; Mon, 5 Nov 2012 18:17:04 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 70ZpCNs1j3X2 for ; + Mon, 5 Nov 2012 18:17:04 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 57E9B431FAE + for ; Mon, 5 Nov 2012 18:17:04 -0800 (PST) +Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.89.108] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) + id 1TVYio-0004wt-6m; Mon, 05 Nov 2012 22:17:00 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1TVYiS-0004ns-NR; Mon, 05 Nov 2012 22:16:36 -0400 +From: David Bremner +To: Daniel , Louis Rilling +Subject: Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes +In-Reply-To: <20121106001633.GA14918@kelebek.lublin.se> +References: <20121106001633.GA14918@kelebek.lublin.se> +User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-pc-linux-gnu) +Date: Mon, 05 Nov 2012 22:16:36 -0400 +Message-ID: <87d2zro4qj.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 06 Nov 2012 02:17:05 -0000 + +Daniel writes: + +> On Mon, Nov 21, 2011 at 08:41:42PM -0400, David Bremner wrote: +>> I pushed the first two patches in this series; the second two need to be +>> updated for the new "broken test" framework, and reviewed. +> +> And old one... What came of this patch? +> +> I came across it, having been annoyed by the fact that notmuch broke my reading +> habits by marking messages (in the mutt sense) as seen, which I hadn't really +> seen yet in mutt. I tried out the patch; it applied and seems to work. What can +> I do to make it be applied? Other than giving it some attention. I must say +> that I have zero insight in the test framework, but if that's what's needed +> from me... + +The patches need to be reviewed for correctness and style. Typically any +non-trivial patch (or series) needs two reviews. You can see examples in +the archives of how this works. They are currently marked stale, which +is supposed to mean they no long apply. On the other hand, if they apply +for you, maybe that tagging is wrong (see http://notmuchmail.org/nmbug/ +for more information about patch tagging). + +By the way, it seems like commit b88030b might be relevant. + +d -- 2.26.2