From 4d11c74fae63fed0aeb1ed43942ef5391bfb7431 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Thu, 29 Mar 2012 22:08:31 +2000 Subject: [PATCH] Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal --- a0/e522cec5de71ab42fe89baba0c7b6796d044a6 | 95 +++++++++++++++++++++++ 1 file changed, 95 insertions(+) create mode 100644 a0/e522cec5de71ab42fe89baba0c7b6796d044a6 diff --git a/a0/e522cec5de71ab42fe89baba0c7b6796d044a6 b/a0/e522cec5de71ab42fe89baba0c7b6796d044a6 new file mode 100644 index 000000000..d3e40e3e6 --- /dev/null +++ b/a0/e522cec5de71ab42fe89baba0c7b6796d044a6 @@ -0,0 +1,95 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 61AF4431FAF + for ; Wed, 28 Mar 2012 19:08:35 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id DCj6GzJQ0C4H for ; + Wed, 28 Mar 2012 19:08:34 -0700 (PDT) +Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU + [18.7.68.34]) + by olra.theworths.org (Postfix) with ESMTP id C55EE431FAE + for ; Wed, 28 Mar 2012 19:08:34 -0700 (PDT) +X-AuditID: 12074422-b7fd66d0000008f9-2d-4f73c422d9f5 +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP + id 01.B8.02297.224C37F4; Wed, 28 Mar 2012 22:08:34 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q2T28XbQ013096; + Wed, 28 Mar 2012 22:08:34 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2T28VYo002161 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 28 Mar 2012 22:08:32 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SD4mt-0006LK-Cp; Wed, 28 Mar 2012 22:08:31 -0400 +Date: Wed, 28 Mar 2012 22:08:31 -0400 +From: Austin Clements +To: Jameson Graef Rollins +Subject: Re: [PATCH] emacs: Fix mis-named argument to + notmuch-get-bodypart-internal +Message-ID: <20120329020831.GZ2670@mit.edu> +References: <1332812426-26684-1-git-send-email-amdragon@mit.edu> + <87ty18kwmd.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87ty18kwmd.fsf@servo.finestructure.net> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42IRYrdT0VU6UuxvsOOnoMWefV4W12/OZHZg + 8rh7msvj2apbzAFMUVw2Kak5mWWpRfp2CVwZR09tYC+Yy14xZ6pSA+MN1i5GTg4JAROJ/y+a + 2SFsMYkL99azdTFycQgJ7GOUuHvwCCOEs4FRYv+eDqjMSSaJC9u/MYK0CAksYZTYMtO1i5GD + g0VAVeLNbQWQMJuAhsS2/cvBSkQEzCR6vvwBs5kFpCW+/W5mArGFBUIlnkx/wwJi8wpoS5x+ + vxZqZLbEupYFrBBxQYmTM5+wQPRqSdz495IJZBXInOX/OEDCnAKmEtOWdIGNFBVQkZhychvb + BEahWUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGuqV5uZoleakrpJkZwOLso + 7WD8eVDpEKMAB6MSD+8pzWJ/IdbEsuLK3EOMkhxMSqK88w4DhfiS8lMqMxKLM+KLSnNSiw8x + SnAwK4nw+u0GyvGmJFZWpRblw6SkOViUxHnVtd75CQmkJ5akZqemFqQWwWRlODiUJHhXgAwV + LEpNT61Iy8wpQUgzcXCCDOcBGr4PpIa3uCAxtzgzHSJ/ilGXY927K5cZhVjy8vNSpcR5O0CK + BECKMkrz4ObA0tArRnGgt4R5J4BU8QBTGNykV0BLmICWLDmSD7KkJBEhJdXAmH7njEbALv9K + 1eJvdV6tGTK7F6lNND4SavyjrnljdTW/SZXA4YUBfqeNjvddkux78E7wwWwdTcv7N/Q/RNTP + OtcnFcCyTuaDTOCiEKYdbmsbdIxqBDW1y8uknGbZKpvMXZj1VuDXyhAn/0LTe93zFud+9thq + +evXC/PXGVwbJOdLTnvmdqpNiaU4I9FQi7moOBEA9at6DR4DAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 29 Mar 2012 02:08:35 -0000 + +Quoth Jameson Graef Rollins on Mar 28 at 6:46 pm: +> On Mon, Mar 26 2012, Austin Clements wrote: +> > Previously, this function took an argument called "message-id", even +> > though it was a general query, rather than a message ID. This changes +> > it to "query". +> +> I'm sure the argument was named such because: the function is retrieving +> a message part so the query has to match just a single message, and it's +> only ever given a message id by anything that calls it. And it's an +> unexposed internal function. All of this to say that I think it doesn't +> really matter that the argument was named as it was. + +All true. But there's a difference between a message ID and an id: +query and the argument name threw me off for a moment when I was +writing the id: query quoting patch. It could be `id-query', I +suppose, but really it could be any query that matches a single +message. -- 2.26.2