From 49dec88e62a3922bc430ee991c6f5d050acec0c3 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Sat, 17 Mar 2012 23:02:25 +1700 Subject: [PATCH] Re: [Patch v2 0/3] Add test and fix exclude bug --- ac/1074e6f858e86c4db283986416366265632a00 | 105 ++++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 ac/1074e6f858e86c4db283986416366265632a00 diff --git a/ac/1074e6f858e86c4db283986416366265632a00 b/ac/1074e6f858e86c4db283986416366265632a00 new file mode 100644 index 000000000..14bfc9c85 --- /dev/null +++ b/ac/1074e6f858e86c4db283986416366265632a00 @@ -0,0 +1,105 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 90C39431FBF + for ; Fri, 16 Mar 2012 23:02:36 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 4nl6GIIqeWgz for ; + Fri, 16 Mar 2012 23:02:35 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 67F61431FB6 + for ; Fri, 16 Mar 2012 23:02:34 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id E030F66E00DD; + Fri, 16 Mar 2012 23:02:31 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (cpe-74-66-81-190.nyc.res.rr.com + [74.66.81.190]) (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 106D066E0108; + Fri, 16 Mar 2012 23:02:29 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 154A74A8; Fri, 16 Mar 2012 23:02:26 -0700 (PDT) +From: Jameson Graef Rollins +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [Patch v2 0/3] Add test and fix exclude bug +In-Reply-To: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com> +References: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.11.1+306~g05d342c (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 16 Mar 2012 23:02:25 -0700 +Message-ID: <87limzepe6.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 17 Mar 2012 06:02:37 -0000 + +--=-=-= +Content-Transfer-Encoding: quoted-printable + +On Wed, 14 Mar 2012 12:26:51 +0000, Mark Walters wrote: +> The test in the previous patches +> id:"1331551914-28323-1-git-send-email-markwalters1009@gmail.com" +> triggered the bug accidentally. It accidentally set the exclude tags +> to be "=3D" and "deleted" rather than just "deleted". The non-existent +> "=3D" tag (i.e., the tag that does not occur anywhere in the Xapian +> database) triggered the bug. First we correct the tests to just set +> the "deleted" tag, then we add some tests including one with a +> deliberately non-existent tag. Finally, we modify the exclusion code +> to avoid the bug. +>=20 +> The modification also appears to fix a similar problem for jrollins +> that I have not yet been able to reproduce. +>=20 +> Since the code is now more clearly correct, cleaner and we do +> definitely avoid a Xapian bug I think these patches can be committed +> even without knowing why it fixed jrollins' bug. +>=20 +> Finally these apply to current master (not to the --with-excluded series). + +tested, and it works for me, so LGTM. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iQIcBAEBCAAGBQJPZCjxAAoJEO00zqvie6q88ZsQALW3GWKh7IXsI/Z/s2gjdNqh +FwVhXQjsibRLxvZ8FvXhPp7iU6mwn8maBLLe8uEUdvGdf4e55/Uf4GF1zjWHOQvN +eevD9wiV55z+uVA4hmp0VGC69rgoPGlb+BUcdQKUj2CnbRuydOObXUUqJbNKFksA +LrneTwEGgiw0ogSoymjkXd3Jj+aaWuEyx9FPyvme16Q3JcqMeeCpqXOb0n8m2x8c +9a+4nD7TxeRkCSVDbvVfV0ecOmPr7D6IrcLUYZd8wK//hdKTWVSN1DY8De4mQA78 +vthnh1p4ArCXoiSlf4yUotLz0h0xNmvsKWoY6wGIvgYVaEVeClj7ELNsubx8mu3J +J2OvXN8gU1TM8X122r8/rIdQBXy0zgqus6ysqgcCDo0zsb4tI44xnZMAy+yixwqs +OBFkAMQrfL10KzECSvts9J4geXG9CJovAFbSSWCFwdI391zuaCXhVYJaqljsbuHg +aSqxdne8ukcK/oPf8doXq/rHoeAgBy4e62MZjKISGHpm9T1MWTL9Vr5TmKtHskDB +sFqOCPj8bbzrfbwOi06B40lEB8zg1MX2untTBsKj3449eoWl1DCHdn8JlS40IpDF +snJD1efGqvRtLkxlpsekp/+zjXfax4ppsehGdPB7C4f2/aU4gv4D64HRKiQs8L6E +Yy1ZFNJOMr06CJARZAbe +=yO6E +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2