From 494e2a47cd732ffcd53c0f0d4ca7a51d2501f800 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Fri, 3 Feb 2012 10:00:59 +1600 Subject: [PATCH] Re: [PATCH 1/2] test: add check for filename argument for test_expect_equal_file --- ea/466ca4ecfe185a0cb91464bacf3b89c54aadd0 | 90 +++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 ea/466ca4ecfe185a0cb91464bacf3b89c54aadd0 diff --git a/ea/466ca4ecfe185a0cb91464bacf3b89c54aadd0 b/ea/466ca4ecfe185a0cb91464bacf3b89c54aadd0 new file mode 100644 index 000000000..e8eb717ec --- /dev/null +++ b/ea/466ca4ecfe185a0cb91464bacf3b89c54aadd0 @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 9405B431FBD + for ; Thu, 2 Feb 2012 10:01:03 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2UdnI+21-DsR for ; + Thu, 2 Feb 2012 10:01:03 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 41C9E431FAF + for ; Thu, 2 Feb 2012 10:01:03 -0800 (PST) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id DF9CD66E01C8; + Thu, 2 Feb 2012 10:01:02 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com + [76.174.137.84]) (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 3027E66E0170; + Thu, 2 Feb 2012 10:01:00 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id E3BD4291; Thu, 2 Feb 2012 10:00:59 -0800 (PST) +From: Jameson Graef Rollins +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] test: add check for filename argument for + test_expect_equal_file +In-Reply-To: <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com> +References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com> + <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com> +User-Agent: Notmuch/0.11+128~g6f388fa (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 02 Feb 2012 10:00:59 -0800 +Message-ID: <87zkd1p12c.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 02 Feb 2012 18:01:03 -0000 + +--=-=-= + +Hey, Dmitry. I'm so sorry I sent my last email on your original patch +before I saw this new series. I do now like your original proposal +better, since it shows the diff based the names the caller provides, +which I now agree is probably the clearest and most robust solution. +The second patch in this series could still go through, though, no +matter what version of the change to test_expect_equal_file we go with. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iQIcBAEBCAAGBQJPKs9bAAoJEO00zqvie6q8KugP/0VGzl0vuFaCMSHtJyvCKzOV +M3qmgW4viMyTov4NYj/EtdAnRbq0pYkhu2+waCjVZ/CMLK7dCIa9NDI2WznMah8R +Y4Kl5KlvxTA2cFSvJQJ+HRkFINDiYutjCnWzuqO3oBVWjYf8LcLiP4dZht5+mDRR +rrsTd3EKIRXV3pXCM8a/nJFqznNRevKc/wn6r3SK517w5+S/6131iBurppl16nUd +t7pi5CVxcBTHBzYyveC5fmIvAbmMe/loDQSVlp8wWbpO9OGUzq8HmqhRXDalNwDV +hrGnW4dHpmduvYil8IcJKBzAX5hOm4avt/7UAfl9dhVA1V+fNBr+nxF2XR7nhtZf +e4IldaVS+tD3hy7NPlwevNz8VM81m/07GYCjWcIg1f50iKb6MvwuNakz4dPmJ4UH +vKjWAYwEjwHTrXd4Im/6DcoAa3Jc7/A0CMadGajfij20UONUjSGJWEs5lu9787pz +3C6YdwrrSexUa3e+OQ2an0kVK3HIUHsg/ltO5CG3Sf7dQHoOeEej9+ynilWXiYtk +MXgBxmKHFq2trfSGfoE2vndp86rKSNzoASF81jm3Mdy5nf3F+z1VKkitmftnTBzG +xnWRUGYMWGHyM1PMWMl1I1RWm8s8ZTzDn1bf4JnJj2RjO41tZYWvj3GJR/v5x2Co +z96o+Gn6LmW1PisBXfNN +=jTqi +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2