From 44d0991c732f8d92cf6fa3977c789d0f9e971771 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 5 Feb 2012 12:41:40 +0000 Subject: [PATCH] Re: [PATCH v3 4/5] emacs: Use the new JSON reply format. --- 07/f2958c18178e2f3793a9962b7ffb2869cf7e65 | 110 ++++++++++++++++++++++ 1 file changed, 110 insertions(+) create mode 100644 07/f2958c18178e2f3793a9962b7ffb2869cf7e65 diff --git a/07/f2958c18178e2f3793a9962b7ffb2869cf7e65 b/07/f2958c18178e2f3793a9962b7ffb2869cf7e65 new file mode 100644 index 000000000..8101321e6 --- /dev/null +++ b/07/f2958c18178e2f3793a9962b7ffb2869cf7e65 @@ -0,0 +1,110 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 95C10431FAF + for ; Sun, 5 Feb 2012 04:40:33 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id wnIBcdSzTPwg for ; + Sun, 5 Feb 2012 04:40:33 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DA98C431FAE + for ; Sun, 5 Feb 2012 04:40:32 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Ru1OR-0001O5-6D; Sun, 05 Feb 2012 12:40:31 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1Ru1OQ-000239-T5; Sun, 05 Feb 2012 12:40:31 +0000 +From: Mark Walters +To: Adam Wolfe Gordon , notmuch@notmuchmail.org +Subject: Re: [PATCH v3 4/5] emacs: Use the new JSON reply format. +In-Reply-To: <1326995217-27423-5-git-send-email-awg+notmuch@xvx.ca> +References: <1326995217-27423-1-git-send-email-awg+notmuch@xvx.ca> + <1326995217-27423-5-git-send-email-awg+notmuch@xvx.ca> +User-Agent: Notmuch/0.11+154~ged6d37e (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Sun, 05 Feb 2012 12:41:40 +0000 +Message-ID: <874nv5wiyj.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 6b6e291cb50986a30b0f1a5fc0c9c3d2 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Feb 2012 12:40:33 -0000 + +On Thu, 19 Jan 2012 10:46:56 -0700, Adam Wolfe Gordon wrote: +> Using the new JSON reply format allows emacs to quote HTML +> parts nicely by using mm-display-part to turn them into displayable +> text, then quoting them. This is very useful for users who +> regularly receive HTML-only email. +> +> The behavior for messages that contain plain text parts should be +> unchanged. + +Hi I have tried using this patch and it did give an identical emacs +buffer when replying to text/plain or multipart/alternative messages +except for two things: + +the old one put a line in the reply for each attachment not being +included in the reply (eg "Attachment: file.pdf (application/pdf)" ) and +the new one does not. + +and your version does not include text/plain attachments with +disposition attachment (obviously as the cli part does not). + +[Note I am not saying whether either of these correct or not, just that +they are changes.] + +It also worked nicely on the html only messages I tried it on. + +I have not reviewed the lisp yet; I will try and have a look at it but I +am a lisp beginner. + +Best wishes + +Mark + +PS Sorry I sent this from my unsubscribed address first: since I am +using your patch-set my recent reply From: modification wasn't there! -- 2.26.2