From 448897158f19b8417f413c16a47de38dffe14346 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Tue, 17 Apr 2012 09:14:23 +0300 Subject: [PATCH] [PATCH] configure: test shell parameter substring processing and possibly exec one --- 6d/47130e645a817ce6c071c9e39ccb36803d606e | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 6d/47130e645a817ce6c071c9e39ccb36803d606e diff --git a/6d/47130e645a817ce6c071c9e39ccb36803d606e b/6d/47130e645a817ce6c071c9e39ccb36803d606e new file mode 100644 index 000000000..0d2138b8d --- /dev/null +++ b/6d/47130e645a817ce6c071c9e39ccb36803d606e @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 39BD1431FB6 + for ; Mon, 16 Apr 2012 23:14:38 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OO8UHsRLv-hr for ; + Mon, 16 Apr 2012 23:14:34 -0700 (PDT) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id D4769431FAE + for ; Mon, 16 Apr 2012 23:14:33 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 1991C68055; Tue, 17 Apr 2012 09:14:30 +0300 (EEST) +From: Tomi Ollila +To: notmuch@notmuchmail.org +Subject: [PATCH] configure: test shell parameter substring processing and + possibly exec one +Date: Tue, 17 Apr 2012 09:14:23 +0300 +Message-Id: <1334643263-30207-1-git-send-email-tomi.ollila@iki.fi> +X-Mailer: git-send-email 1.7.6.1 +In-Reply-To: <1334589199-25894-1-git-send-email-tomi.ollila@iki.fi> +References: <1334589199-25894-1-git-send-email-tomi.ollila@iki.fi> +Cc: Tomi Ollila +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 17 Apr 2012 06:14:38 -0000 + +'configure' script uses parameter substring extensively. It is Posix shell +feature. Original Bourne shell does not have such features. Some systems +still ships such shells as /bin/sh (for compatibility reasons -- shell +scripts written on those platforms are expected to work on 1990's systems...) + +To tackle this situation the beginning of configure attemts to do a silent +parameter substitution in a subshell; in case this fails the subshell exits +with nonzero value which is easy to detect. + +The || constructs are used twice. The first one is used as Bourne shell +chokes on 'if ! ... ' construct (and if ...; then :; else do_things; fi +looks stupid). The second one(liner) takes care of the possible future +addition of 'set -eu' in the beginning of this script. +--- + +This patch obsoleted id:"1334589199-25894-1-git-send-email-tomi.ollila@iki.fi" +diff: +-+ NOTMUCH_CONFIGURE=1; export _NOTMUCH_CONFIGURE +++ _NOTMUCH_CONFIGURE=1; export _NOTMUCH_CONFIGURE + + +This patch obsoletes id:"1333966665-10469-2-git-send-email-Vladimir.Marek@oracle.com" + + configure | 14 ++++++++++++++ + 1 files changed, 14 insertions(+), 0 deletions(-) + +diff --git a/configure b/configure +index 71981b7..06fbeff 100755 +--- a/configure ++++ b/configure +@@ -1,6 +1,19 @@ + #! /bin/sh + ++# Test whether this sh is capable of parameter substring processing. ++# If not, attempt to locate and launch one which probably can. ++( option=option=value; : ${option#*=} ) 2>/dev/null || { ++ if test x"${_NOTMUCH_CONFIGURE-}" = x ; then ++ _NOTMUCH_CONFIGURE=1; export _NOTMUCH_CONFIGURE ++ for x in /bin/ksh /bin/bash /usr/bin/bash ++ do test ! -x "$x" || exec "$x" "$0" "$@" ++ done ++ fi ++ echo "Cannot find compatible shell to execute '$0'" >&2 ++ exit 1 ++} ++unset _NOTMUCH_CONFIGURE ++ + # Store original IFS value so it can be changed (and restored) in many places. + readonly DEFAULT_IFS=$IFS + +-- +1.7.8.2 + -- 2.26.2