From 444d692e2c9a40d37c33bf07689fab4ca8258cc8 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Fri, 6 Apr 2012 16:38:20 +0100 Subject: [PATCH] Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag) --- a2/6a5c7ff4cb8a0296b8830476fcbe0e38d901e5 | 111 ++++++++++++++++++++++ 1 file changed, 111 insertions(+) create mode 100644 a2/6a5c7ff4cb8a0296b8830476fcbe0e38d901e5 diff --git a/a2/6a5c7ff4cb8a0296b8830476fcbe0e38d901e5 b/a2/6a5c7ff4cb8a0296b8830476fcbe0e38d901e5 new file mode 100644 index 000000000..cb89da1f2 --- /dev/null +++ b/a2/6a5c7ff4cb8a0296b8830476fcbe0e38d901e5 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C8585431FB6 + for ; Fri, 6 Apr 2012 08:38:18 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.401 +X-Spam-Level: * +X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id AxxN-3h5Rfj6 for ; + Fri, 6 Apr 2012 08:38:16 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 270E3431FAE + for ; Fri, 6 Apr 2012 08:38:15 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SGBEo-0001sI-Pj; Fri, 06 Apr 2012 16:38:11 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SGBEo-0000iY-FH; Fri, 06 Apr 2012 16:38:10 +0100 +From: Mark Walters +To: Jameson Graef Rollins , + notmuch@notmuchmail.org +Subject: Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag) +In-Reply-To: <87bon47v0o.fsf@servo.finestructure.net> +References: <1333716551-29153-1-git-send-email-markwalters1009@gmail.com> + <87bon47v0o.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.12+96~g8f5ec3b (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 06 Apr 2012 16:38:20 +0100 +Message-ID: <87ty0w50r7.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 1e624825d6275d7cbb637cd4d1746cd9 (of first 20000 bytes) +X-SpamAssassin-Score: -1.2 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.2 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 1.0 FREEMAIL_REPLY From and body contain different freemails + * 0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 06 Apr 2012 15:38:18 -0000 + +On Fri, 06 Apr 2012, Jameson Graef Rollins wrote: +> On Fri, Apr 06 2012, Mark Walters wrote: +>> This is the latest version of the patch series (previous version at [1]). +>> I think this version fixes all the problems raised by Austin in his review. +> +> Tested and reviewed and LGTM. +> +> Unfortunately, though, I just now noticed that the tests don't cover +> count and show excludes. Since everything else looks good, let's just +> make a new version of [0]. I suggest we name the new test script just +> "excludes" and then add count and show tests there. That should be +> pretty straightforward. + +There are some exclude tests for count in test/count. Do you think it +needs to be a full test everything like in test/search-exclude? + +There aren't any tests for show exclude, but there aren't very many +tests explicitly for show anyway. My preference would be to add +something like +id:"1332171061-27983-1-git-send-email-markwalters1009@gmail.com" and add +some tests to that. I could add some tests for show-excludes in the same format +as the search-exclude tests though if you think that is better. + +Best wishes + +Mark +> +> Thanks again, Mark. +> +> jamie. +> +> [0] id:"1333716551-29153-5-git-send-email-markwalters1009@gmail.com" -- 2.26.2