From 43f70d2b29c7819351c83a455685e2d419126a2f Mon Sep 17 00:00:00 2001 From: Sebastian Spaeth Date: Fri, 20 Apr 2012 15:10:04 +0200 Subject: [PATCH] Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor --- 01/c34ffb6d94fa9eac8d0aab9293743439973363 | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 01/c34ffb6d94fa9eac8d0aab9293743439973363 diff --git a/01/c34ffb6d94fa9eac8d0aab9293743439973363 b/01/c34ffb6d94fa9eac8d0aab9293743439973363 new file mode 100644 index 000000000..662708cee --- /dev/null +++ b/01/c34ffb6d94fa9eac8d0aab9293743439973363 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 78BDA431FB6 + for ; Sat, 21 Apr 2012 04:22:50 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.09 +X-Spam-Level: +X-Spam-Status: No, score=-0.09 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_NONE=-0.0001, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id KQNGxe6QxjJG for ; + Sat, 21 Apr 2012 04:22:46 -0700 (PDT) +Received: from homiemail-a76.g.dreamhost.com (caiajhbdcahe.dreamhost.com + [208.97.132.74]) + by olra.theworths.org (Postfix) with ESMTP id 6EF20431FAE + for ; Sat, 21 Apr 2012 04:22:46 -0700 (PDT) +Received: from homiemail-a76.g.dreamhost.com (localhost [127.0.0.1]) + by homiemail-a76.g.dreamhost.com (Postfix) with ESMTP id ABA73458079; + Sat, 21 Apr 2012 04:22:39 -0700 (PDT) +DomainKey-Signature: a=rsa-sha1; c=nofws; d=SSpaeth.de; h=from:to:cc:subject + :in-reply-to:references:date:message-id:mime-version: + content-type; q=dns; s=sspaeth.de; b=nrMjZ85usbTILNSuLarP0osT+3y + /hiojJUu8OW2qM6COI8k7wwwWELP07sfV0N9nuikk1pnxUmY+QJwzkrMK7DQl7FR + +rTjDZB8tMLqMWFWxwrmxR0ODMxbrfYWxcuNSzPxiUsUtZJqcKHkE78c5UqLPUqV + jP6gD6HflBg4AVN8= +DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=SSpaeth.de; h=from:to:cc + :subject:in-reply-to:references:date:message-id:mime-version: + content-type; s=sspaeth.de; bh=yXvFYWXTw1mmryQPalG3OULsR/0=; b=J + jgGLlepwKkRC1LwPfRy5yparaQPSPuiXxfcXfJIbqL78/EoZpp/Wrg1JT+kpBQfc + kEySoBwoPwp3ApDUjkTw2GbdIKiPCPyut56Pd/wc+Ep4+0bjYFQZJVoUqPeof99/ + +9anVw9ePTKrV4CbjjfsUXGWL41QDaEwE/SXRNpGXA= +Received: from spaetzbook (unknown [176.46.208.243]) + (Authenticated sender: fax@sspaeth.de) + by homiemail-a76.g.dreamhost.com (Postfix) with ESMTPA id 5613D458071; + Sat, 21 Apr 2012 04:22:39 -0700 (PDT) +Received: by spaetzbook (Postfix, from userid 1000) + id B57AE1600B9; Fri, 20 Apr 2012 15:10:11 +0200 (CEST) +From: Sebastian Spaeth +To: Austin Clements , + Justus Winter <4winter@informatik.uni-hamburg.de> +Subject: Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as + destructor +In-Reply-To: <20120412170249.GG13549@mit.edu> +References: + <1332291311-28954-1-git-send-email-4winter@informatik.uni-hamburg.de> + <1332291311-28954-8-git-send-email-4winter@informatik.uni-hamburg.de> + <20120412170249.GG13549@mit.edu> +User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 20 Apr 2012 15:10:04 +0200 +Message-ID: <87ty0ek0r7.fsf@sspaeth.de> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 21 Apr 2012 11:22:50 -0000 + +--=-=-= + +Austin Clements writes: +> (I think it also doesn't make sense to expose notmuch_database_destroy +> as a general, public method since it will free all of the other C +> objects out from under the bindings, resulting in exactly the double +> free-type crashes that you're trying to avoid. It appears that none +> of the other Python classes have a destroy method.) + +Agreed, that sounds right to me. + +Sebastian + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iEYEARECAAYFAk+RYCwACgkQVYX1jMgnoGKK5gCfVFw75E2kRgeK8Vrwuyhl99Bd +fRgAnj7ygCFj2wJzS/OoInLkNqEKlDtI +=m5GA +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2