From 409f6207f1d19645329422cd582e63b9868c0535 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Mon, 21 Jan 2013 13:55:14 +1600 Subject: [PATCH] Re: [PATCH 5/7] CLI: add --leak-report top level option --- 00/16bd42a6397591079d061f95590736323be38f | 115 ++++++++++++++++++++++ 1 file changed, 115 insertions(+) create mode 100644 00/16bd42a6397591079d061f95590736323be38f diff --git a/00/16bd42a6397591079d061f95590736323be38f b/00/16bd42a6397591079d061f95590736323be38f new file mode 100644 index 000000000..f1ed69b77 --- /dev/null +++ b/00/16bd42a6397591079d061f95590736323be38f @@ -0,0 +1,115 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id CE125431FBD + for ; Sun, 20 Jan 2013 13:55:27 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Fhw-01x1Tqck for ; + Sun, 20 Jan 2013 13:55:25 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 87AF6431FAF + for ; Sun, 20 Jan 2013 13:55:25 -0800 (PST) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id 168A1328171; + Sun, 20 Jan 2013 13:55:23 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (cpe-76-166-145-133.socal.res.rr.com + [76.166.145.133]) (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id 3ED3C328172; + Sun, 20 Jan 2013 13:55:19 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id 2BCF661761; Sun, 20 Jan 2013 13:55:17 -0800 (PST) +From: Jameson Graef Rollins +To: david@tethera.net, notmuch@notmuchmail.org +Subject: Re: [PATCH 5/7] CLI: add --leak-report top level option +In-Reply-To: <1358619958-21209-6-git-send-email-david@tethera.net> +References: <1358619958-21209-1-git-send-email-david@tethera.net> + <1358619958-21209-6-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.14+249~gbbd600f (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Sun, 20 Jan 2013 13:55:14 -0800 +Message-ID: <87d2wzwmd9.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +Cc: David Bremner +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 20 Jan 2013 21:55:27 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Sat, Jan 19 2013, david@tethera.net wrote: +> This roughly mimics the samba4 argument. The presence of the command +> line argument overrides any value of NOTMUCH_TALLOC_REPORT in the +> environment. +> --- +> man/man1/notmuch.1 | 8 ++++++++ +> notmuch.c | 18 +++++++----------- +> 2 files changed, 15 insertions(+), 11 deletions(-) +> +> diff --git a/man/man1/notmuch.1 b/man/man1/notmuch.1 +> index 6bf9b2e..5c58c41 100644 +> --- a/man/man1/notmuch.1 +> +++ b/man/man1/notmuch.1 +> @@ -70,6 +70,14 @@ Print a synopsis of available commands and exit. +> Print the installed version of notmuch, and exit. +> .RE +>=20=20 +> +.RS 4 +> +.TP 4 +> +.BI \-\-leak-report=3D path +> + +> +Write a detailed report of all memory allocated via talloc to +> +.I path +> +.RE + +Do we really need a command line option for this? Why isn't the env var +sufficient? This just seems to me like it clutters the interface, for +an option that is purely for debugging and should rarely if ever be used +by most users. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJQ/GfCAAoJEO00zqvie6q8IGkP/1eBH3zm106ajGiyaHNfUvbK +1PHkdH3GIFr3FpChi3jO7oxVbAIK1pyWSBe1OxnUVCOaCmXRop59G6aeismA0de2 +pvnXEU9MbRq5eloJWsJacEMjgSS3OS1VKBxwv72W2J72bfiaM1QyjP0tI9cUIyx7 +DaxKAhzpigM+hUGo3WOwcn3f+A7PF5IWGXBraMtff8UrDCnUL3HoztvE6z/EeUtw +FvCkndujCO5Hwn75bwXNMxYo6pm3TMeqypWGqxHlUv6faZWq2SHHGAMXHwkezqbI +my0s1m/AOHwUrX71liSZN5tM9iJJRYypKLyu1kf9UOsoQDWQAvjCwIt7Bd3TXYMh +ZY4SrkiYgU37mIawVSz75zpbPqPG4jnDngfDfCIGWA3oeueoUN5hIYE3hh2zgcvL +b5g2Vyc4YmwSP6SIhUglLmS8uuLHy1l6wej6uigQT5oHh1/1ilFeSGWHZvdLZYMc +A06RhY5VGKi7zKbvoRwDg64Dp7P7tXmhMpXA8KN4TsSTjBL+nIUtqPL9EDLi8jZe +/es+4fDEizP9ok88JMAhSHvniskQEOn1tZ10T/a6CKk2TQEBF0kZ18SiDuRiiPrL +9k3AkRM1YY8gjGeI5DA94bqL4RrJzuEcjfUdQtxtGNX9HSg4xJOYQQwKJ22vudRi +Ggj1d0heKvV+g9uO06yU +=W7TF +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2