From 3ec56d635c4ac905e470330422b1ed0a56eba5a4 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Thu, 6 Dec 2012 22:13:57 +0000 Subject: [PATCH] Re: [PATCH v5 0/5] New output format sexp (Lisp S-Expressions) --- f4/d27e667dbad1dd5177285041db625ba377b6b6 | 132 ++++++++++++++++++++++ 1 file changed, 132 insertions(+) create mode 100644 f4/d27e667dbad1dd5177285041db625ba377b6b6 diff --git a/f4/d27e667dbad1dd5177285041db625ba377b6b6 b/f4/d27e667dbad1dd5177285041db625ba377b6b6 new file mode 100644 index 000000000..04c04d779 --- /dev/null +++ b/f4/d27e667dbad1dd5177285041db625ba377b6b6 @@ -0,0 +1,132 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7C0D3431FB6 + for ; Thu, 6 Dec 2012 14:14:04 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XAx9HPdcOsEQ for ; + Thu, 6 Dec 2012 14:14:02 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3A0D8431FAE + for ; Thu, 6 Dec 2012 14:14:02 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Tgjha-0005Be-Nn; Thu, 06 Dec 2012 22:13:57 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1Tgjha-00073h-E3; Thu, 06 Dec 2012 22:13:54 +0000 +From: Mark Walters +To: Peter Feigl , notmuch@notmuchmail.org +Subject: Re: [PATCH v5 0/5] New output format sexp (Lisp S-Expressions) +In-Reply-To: <1354828335-18151-1-git-send-email-craven@gmx.net> +References: <1354828335-18151-1-git-send-email-craven@gmx.net> +User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 06 Dec 2012 22:13:57 +0000 +Message-ID: <87obi67rru.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 575c9d650e8973f235a9752fd0a325cf (of first 20000 bytes) +X-SpamAssassin-Score: -1.7 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.7 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.6 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 06 Dec 2012 22:14:04 -0000 + + +On Thu, 06 Dec 2012, Peter Feigl wrote: +> This patch series adds a new output format "sexp" to notmuch-reply, +> notmuch-show and notmuch-search. These are useful for the Android mobile +> client, Emacs and perhaps other Lisp programs as well. +> After the switch to a generic structured output printer, which was +> committed some months ago, these patches just add another one (like the +> json structured output printer). +> Basic tests and updates to the man pages are also included. +> +> This version adresses comments by Tomi Ollila and Austin Clements. + +This looks good to me except there are a couple of trailing whitespace +errors + +Best wishes + +Mark + + +> +> Old versions: +> v4: id:cover.1354794428.git.craven@gmx.net +> v3: id:1354779189-12231-1-git-send-email-craven@gmx.net +> v2: id:1354632382-15609-1-git-send-email-craven@gmx.net +> v1: 1354264143-30173-1-git-send-email-craven@gmx.net +> +> Peter Feigl (5): +> Adding an S-expression structured output printer. +> Rename the -json printer functions in notmuch-reply and notmuch-show +> to generic -sprinter functions. +> Use the S-Expression structured printer in notmuch-show, +> notmuch-reply and notmuch-search. +> Adding tests for --format=sexp. +> Updating man pages for new S-Expression output format. +> +> Makefile.local | 1 + +> devel/schemata | 24 +++-- +> man/man1/notmuch-reply.1 | 14 ++- +> man/man1/notmuch-search.1 | 15 +-- +> man/man1/notmuch-show.1 | 36 +++++-- +> notmuch-client.h | 8 +- +> notmuch-reply.c | 48 ++++++---- +> notmuch-search.c | 6 +- +> notmuch-show.c | 76 ++++++++------- +> sprinter-sexp.c | 235 ++++++++++++++++++++++++++++++++++++++++++++++ +> sprinter.h | 4 + +> test/notmuch-test | 1 + +> test/sexp | 48 ++++++++++ +> 13 files changed, 434 insertions(+), 82 deletions(-) +> create mode 100644 sprinter-sexp.c +> create mode 100755 test/sexp +> +> -- +> 1.8.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2