From 3d4a2159fe32c61a9038368f6016faa57d7b7480 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Tue, 8 May 2012 14:09:46 +2000 Subject: [PATCH] [PATCH 2/2] new: Centralize file type stat-ing logic --- 50/43cab6d98e4bf40ae74a18898316a31845f3ac | 249 ++++++++++++++++++++++ 1 file changed, 249 insertions(+) create mode 100644 50/43cab6d98e4bf40ae74a18898316a31845f3ac diff --git a/50/43cab6d98e4bf40ae74a18898316a31845f3ac b/50/43cab6d98e4bf40ae74a18898316a31845f3ac new file mode 100644 index 000000000..8f9092ab2 --- /dev/null +++ b/50/43cab6d98e4bf40ae74a18898316a31845f3ac @@ -0,0 +1,249 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3C709431E64 + for ; Mon, 7 May 2012 11:09:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Igrx-D0+W00L for ; + Mon, 7 May 2012 11:09:58 -0700 (PDT) +Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU + [18.7.68.37]) + by olra.theworths.org (Postfix) with ESMTP id C4DEF431FBC + for ; Mon, 7 May 2012 11:09:57 -0700 (PDT) +X-AuditID: 12074425-b7f966d0000008b6-e1-4fa80ff58dfd +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP + id D4.0B.02230.5FF08AF4; Mon, 7 May 2012 14:09:57 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q47I9u55005941; + Mon, 7 May 2012 14:09:56 -0400 +Received: from drake.mit.edu (26-4-166.dynamic.csail.mit.edu [18.26.4.166]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q47I9tq2003119 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Mon, 7 May 2012 14:09:56 -0400 (EDT) +Received: from amthrax by drake.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SRSNf-0003za-64; Mon, 07 May 2012 14:09:55 -0400 +From: Austin Clements +To: notmuch@notmuchmail.org +Subject: [PATCH 2/2] new: Centralize file type stat-ing logic +Date: Mon, 7 May 2012 14:09:46 -0400 +Message-Id: <1336414186-15293-3-git-send-email-amdragon@mit.edu> +X-Mailer: git-send-email 1.7.10 +In-Reply-To: <1336414186-15293-1-git-send-email-amdragon@mit.edu> +References: <1336414186-15293-1-git-send-email-amdragon@mit.edu> +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsUixCmqrfuVf4W/wY3tyhbXb85ktphxfheL + A5PHs1W3mD2WHf3JGMAUxWWTkpqTWZZapG+XwJVxan4PY0GfUUX7vcnMDYz/1boYOTkkBEwk + Tp5awQphi0lcuLeeDcQWEtjHKLH7VFAXIxeQvZ5R4vjWZkYI5xiTxNz3b1khnPmMEge3fgVr + YRPQkNi2fzkjiC0iIC2x8+5ssLHMAp4SB75NA4sLC9hKnPo9AayeRUBV4uz66ywgNq+Ag0TT + t4dMEGfISzy93wdUw8HBKeAocfi7LMRFDhK3lhxinsDIv4CRYRWjbEpulW5uYmZOcWqybnFy + Yl5eapGuhV5uZoleakrpJkZQILG7qO5gnHBI6RCjAAejEg+v0ovl/kKsiWXFlbmHGCU5mJRE + edfyrvAX4kvKT6nMSCzOiC8qzUktPsQowcGsJML75jtQOW9KYmVValE+TEqag0VJnFdT652f + kEB6YklqdmpqQWoRTFaGg0NJgvcmH9BQwaLU9NSKtMycEoQ0EwcnyHAeoOG3QWp4iwsSc4sz + 0yHypxgVpcR5X4MkBEASGaV5cL2wSH/FKA70ijCvMTDuhXiASQKu+xXQYCagwZufLQMZXJKI + kJJqYJwZ75luLs9w1M5i255/IVsX3lsh2navJtvqe2diZ9ihlee8y62dZhzPLtqb+vy46iLv + ZqlIvXd7Lz4uXvix//X2HRWMLQu1RS0SpsZbGG/dtTaNMWaWp9ulAL1Crs0rcnOZT296maTh + wH16ypwV2j+crh4S+MXLEhxqsIdhpUpvg/mxypitPEosxRmJhlrMRcWJAC8Lp3bPAgAA +Cc: Vladimir Marek +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 07 May 2012 18:09:59 -0000 + +This moves our logic to get a file's type into one function. This has +several benefits: we can support OSes and file systems that do not +provide dirent.d_type or always return DT_UNKNOWN, complex +symlink-handling logic has been replaced by a simple stat fall-through +in one place, and the error message for un-stat-able file is more +accurate (previously, the error always mentioned directories, even +though a broken symlink is not a directory). +--- + notmuch-new.c | 99 ++++++++++++++++++++++++++++++++++----------------------- + test/new | 2 +- + 2 files changed, 60 insertions(+), 41 deletions(-) + +diff --git a/notmuch-new.c b/notmuch-new.c +index cb720cc..cf2580e 100644 +--- a/notmuch-new.c ++++ b/notmuch-new.c +@@ -154,6 +154,44 @@ dirent_sort_strcmp_name (const struct dirent **a, const struct dirent **b) + return strcmp ((*a)->d_name, (*b)->d_name); + } + ++/* Return the type of a directory entry relative to path as a stat(2) ++ * mode. Like stat, this follows symlinks. Returns -1 and sets errno ++ * if the file's type cannot be determined (which includes dangling ++ * symlinks). ++ */ ++static int ++dirent_type (const char *path, const struct dirent *entry) ++{ ++ struct stat statbuf; ++ char *abspath; ++ int err; ++ ++#ifdef _DIRENT_HAVE_D_TYPE ++ /* Mapping from d_type to stat mode_t. We omit DT_LNK so that ++ * we'll fall through to stat and get the real file type. */ ++ static const mode_t modes[] = { ++ [DT_BLK] = S_IFBLK, ++ [DT_CHR] = S_IFCHR, ++ [DT_DIR] = S_IFDIR, ++ [DT_FIFO] = S_IFIFO, ++ [DT_REG] = S_IFREG, ++ [DT_SOCK] = S_IFSOCK ++ }; ++ if (entry->d_type < sizeof(modes)/sizeof(modes[0]) && ++ modes[entry->d_type]) ++ return modes[entry->d_type]; ++#endif ++ ++ abspath = talloc_asprintf (NULL, "%s/%s", path, entry->d_name); ++ if (!abspath) ++ return -1; ++ err = stat(abspath, &statbuf); ++ talloc_free (abspath); ++ if (err < 0) ++ return -1; ++ return statbuf.st_mode & S_IFMT; ++} ++ + /* Test if the directory looks like a Maildir directory. + * + * Search through the array of directory entries to see if we can find all +@@ -162,12 +200,12 @@ dirent_sort_strcmp_name (const struct dirent **a, const struct dirent **b) + * Return 1 if the directory looks like a Maildir and 0 otherwise. + */ + static int +-_entries_resemble_maildir (struct dirent **entries, int count) ++_entries_resemble_maildir (const char *path, struct dirent **entries, int count) + { + int i, found = 0; + + for (i = 0; i < count; i++) { +- if (entries[i]->d_type != DT_DIR && entries[i]->d_type != DT_UNKNOWN) ++ if (dirent_type (path, entries[i]) != S_IFDIR) + continue; + + if (strcmp(entries[i]->d_name, "new") == 0 || +@@ -250,7 +288,7 @@ add_files_recursive (notmuch_database_t *notmuch, + notmuch_status_t status, ret = NOTMUCH_STATUS_SUCCESS; + notmuch_message_t *message = NULL; + struct dirent **fs_entries = NULL; +- int i, num_fs_entries; ++ int i, num_fs_entries, entry_type; + notmuch_directory_t *directory; + notmuch_filenames_t *db_files = NULL; + notmuch_filenames_t *db_subdirs = NULL; +@@ -317,7 +355,7 @@ add_files_recursive (notmuch_database_t *notmuch, + } + + /* Pass 1: Recurse into all sub-directories. */ +- is_maildir = _entries_resemble_maildir (fs_entries, num_fs_entries); ++ is_maildir = _entries_resemble_maildir (path, fs_entries, num_fs_entries); + + for (i = 0; i < num_fs_entries; i++) { + if (interrupted) +@@ -325,17 +363,16 @@ add_files_recursive (notmuch_database_t *notmuch, + + entry = fs_entries[i]; + +- /* We only want to descend into directories. +- * But symlinks can be to directories too, of course. +- * +- * And if the filesystem doesn't tell us the file type in the +- * scandir results, then it might be a directory (and if not, +- * then we'll stat and return immediately in the next level of +- * recursion). */ +- if (entry->d_type != DT_DIR && +- entry->d_type != DT_LNK && +- entry->d_type != DT_UNKNOWN) +- { ++ /* We only want to descend into directories (and symlinks to ++ * directories). */ ++ entry_type = dirent_type (path, entry); ++ if (entry_type == -1) { ++ /* Be pessimistic, e.g. so we don't loose lots of mail ++ * just because a user broke a symlink. */ ++ fprintf (stderr, "Error reading file %s/%s: %s\n", ++ path, entry->d_name, strerror (errno)); ++ return NOTMUCH_STATUS_FILE_ERROR; ++ } else if (entry_type != S_IFDIR) { + continue; + } + +@@ -425,31 +462,13 @@ add_files_recursive (notmuch_database_t *notmuch, + notmuch_filenames_move_to_next (db_subdirs); + } + +- /* If we're looking at a symlink, we only want to add it if it +- * links to a regular file, (and not to a directory, say). +- * +- * Similarly, if the file is of unknown type (due to filesystem +- * limitations), then we also need to look closer. +- * +- * In either case, a stat does the trick. +- */ +- if (entry->d_type == DT_LNK || entry->d_type == DT_UNKNOWN) { +- int err; +- +- next = talloc_asprintf (notmuch, "%s/%s", path, entry->d_name); +- err = stat (next, &st); +- talloc_free (next); +- next = NULL; +- +- /* Don't emit an error for a link pointing nowhere, since +- * the directory-traversal pass will have already done +- * that. */ +- if (err) +- continue; +- +- if (! S_ISREG (st.st_mode)) +- continue; +- } else if (entry->d_type != DT_REG) { ++ /* Only add regular files (and symlinks to regular files). */ ++ entry_type = dirent_type (path, entry); ++ if (entry_type == -1) { ++ fprintf (stderr, "Error reading file %s/%s: %s\n", ++ path, entry->d_name, strerror (errno)); ++ return NOTMUCH_STATUS_FILE_ERROR; ++ } else if (entry_type != S_IFREG) { + continue; + } + +diff --git a/test/new b/test/new +index 26253db..e3900f5 100755 +--- a/test/new ++++ b/test/new +@@ -140,7 +140,7 @@ test_begin_subtest "Broken symlink aborts" + ln -s does-not-exist "${MAIL_DIR}/broken" + output=$(NOTMUCH_NEW 2>&1) + test_expect_equal "$output" \ +-"Error reading directory /run/shm/nm/tmp.new/mail/broken: No such file or directory ++"Error reading file /run/shm/nm/tmp.new/mail/broken: No such file or directory + Note: A fatal error was encountered: Something went wrong trying to read or write a file + No new mail." + rm "${MAIL_DIR}/broken" +-- +1.7.10 + -- 2.26.2