From 35455df295e91ae8e535a8fe90b0df96271a96d9 Mon Sep 17 00:00:00 2001 From: Dmitry Kurochkin Date: Tue, 31 Jan 2012 15:41:05 +0400 Subject: [PATCH] Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body. --- 06/079a0d2001801e440533da193e407a211f7d81 | 113 ++++++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 06/079a0d2001801e440533da193e407a211f7d81 diff --git a/06/079a0d2001801e440533da193e407a211f7d81 b/06/079a0d2001801e440533da193e407a211f7d81 new file mode 100644 index 000000000..43789192a --- /dev/null +++ b/06/079a0d2001801e440533da193e407a211f7d81 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 78CE5429E5B + for ; Tue, 31 Jan 2012 03:42:20 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id LPu0-ksR-Het for ; + Tue, 31 Jan 2012 03:42:19 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A7912429E34 + for ; Tue, 31 Jan 2012 03:42:19 -0800 (PST) +Received: by bke11 with SMTP id 11so2430587bke.26 + for ; Tue, 31 Jan 2012 03:42:16 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=ZkOUcgBODT0bJEu5wMZzxXKciOIACr3BYcwVNN+qufM=; + b=qRMJyUMtPPtP96DDSrE4kk2BQ0f9iOn/SLd1YRSO61cTySOdL4J5J5di5ecxryU1tD + Qm7qxegyEgruFXpzkFeHlY9snha+08ylL5h3GrHyadXYw7JKD6yzgVItERzb8cJBHkZL + M1KJdKzxizvHuoPzZtwtwGMgljykp8ucW1D9M= +Received: by 10.205.141.66 with SMTP id jd2mr4797559bkc.95.1328010136826; + Tue, 31 Jan 2012 03:42:16 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id d2sm44489668bky.11.2012.01.31.03.42.15 + (version=TLSv1/SSLv3 cipher=OTHER); + Tue, 31 Jan 2012 03:42:16 -0800 (PST) +From: Dmitry Kurochkin +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Move the blank line from the bottom of the headers + to the top of the body. +In-Reply-To: <1327942340-23340-1-git-send-email-dme@dme.org> +References: <1327942340-23340-1-git-send-email-dme@dme.org> +User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 31 Jan 2012 15:41:05 +0400 +Message-ID: <87vcnsm75a.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 31 Jan 2012 11:42:20 -0000 + +On Mon, 30 Jan 2012 16:52:20 +0000, David Edmondson wrote: +> The blank line doesn't really change position, but is now considered +> to be part of the body rather than part of the headers. This means +> that it is visible when the body is visible rather than when the +> headers are visible. +> --- +> +> I'm interested in getting feedback on this. +> +> Unless you run with `notmuch-message-headers-visible' set to `nil' or +> regularly toggle header visibility, you probably don't care. +> + ++1 + +Regards, + Dmitry + +> emacs/notmuch-show.el | 4 ++-- +> 1 files changed, 2 insertions(+), 2 deletions(-) +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 84ac624..73f73d4 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -854,8 +854,6 @@ current buffer, if possible." +> ;; compatible with the existing implementation. This just sets it +> ;; to after the first header. +> (notmuch-show-insert-headers headers) +> - ;; Headers should include a blank line (backwards compatibility). +> - (insert "\n") +> (save-excursion +> (goto-char content-start) +> ;; If the subject of this message is the same as that of the +> @@ -870,6 +868,8 @@ current buffer, if possible." +> (setq notmuch-show-previous-subject bare-subject) +> +> (setq body-start (point-marker)) +> + ;; A blank line between the headers and the body. +> + (insert "\n") +> (notmuch-show-insert-body msg (plist-get msg :body) depth) +> ;; Ensure that the body ends with a newline. +> (unless (bolp) +> -- +> 1.7.8.3 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2