From 34c7610f284bfe6606b5878975c93fc9d3121f8d Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Wed, 25 Apr 2012 09:06:15 +0100 Subject: [PATCH] Re: [PATCH v4 0/6] Config-related patches --- f5/52e51305439f7f142054084c035c11c506e06a | 104 ++++++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 f5/52e51305439f7f142054084c035c11c506e06a diff --git a/f5/52e51305439f7f142054084c035c11c506e06a b/f5/52e51305439f7f142054084c035c11c506e06a new file mode 100644 index 000000000..051f7746d --- /dev/null +++ b/f5/52e51305439f7f142054084c035c11c506e06a @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id AFA1F431FAF + for ; Wed, 25 Apr 2012 01:05:58 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id LZqhjm7NINSM for ; + Wed, 25 Apr 2012 01:05:58 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 412FA431FAE + for ; Wed, 25 Apr 2012 01:05:58 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SMxEa-00016E-PG; Wed, 25 Apr 2012 09:05:56 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SMxEa-0004M4-Gn; Wed, 25 Apr 2012 09:05:56 +0100 +From: Mark Walters +To: Peter Wang , notmuch@notmuchmail.org +Subject: Re: [PATCH v4 0/6] Config-related patches +In-Reply-To: <87zkaelnxr.fsf@qmul.ac.uk> +References: <1332282698-7951-1-git-send-email-novalazy@gmail.com> + <1334367666-10954-1-git-send-email-novalazy@gmail.com> + <87zkaelnxr.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.12+128~g0f26d91 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 25 Apr 2012 09:06:15 +0100 +Message-ID: <87k414i6bs.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 200d15500e8edaff2f20e72d6c023575 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 25 Apr 2012 08:05:58 -0000 + + +On Sat, 14 Apr 2012, Mark Walters wrote: +> On Sat, 14 Apr 2012, Peter Wang wrote: +>> Changes from v3: +>> - rephrase part of the 'list' implementation as a separate patch +>> - test 'set' on an extant key +>> - test removing keys +> +> This looks good to me. +1 +> +> Two minor comments which you might like to consider (but definitely are +> not required): +> 1) You could check that there are no further arguments when the user +> calls `notmuch config list' +> 2) In the man page you could explicitly say what the output is for a +> configuration item which has not been set. +> +> Best wishes +> +> Mark + +Just to make it completely clear the above was not meant to delay +acceptance of this series: I am quite happy with it as is. + +Best wishes + +Mark -- 2.26.2