From 342e13244846dd8d6514e041e0bf35f959103cc4 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Thu, 15 Mar 2012 18:16:01 +2000 Subject: [PATCH] Re: Patches for 0.12 --- eb/6fb725030e6e6712cdd24a68ecdba02955abdb | 130 ++++++++++++++++++++++ 1 file changed, 130 insertions(+) create mode 100644 eb/6fb725030e6e6712cdd24a68ecdba02955abdb diff --git a/eb/6fb725030e6e6712cdd24a68ecdba02955abdb b/eb/6fb725030e6e6712cdd24a68ecdba02955abdb new file mode 100644 index 000000000..5bd322cea --- /dev/null +++ b/eb/6fb725030e6e6712cdd24a68ecdba02955abdb @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 692A5431FAF + for ; Wed, 14 Mar 2012 15:16:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id GmZIEIHYk1g4 for ; + Wed, 14 Mar 2012 15:16:03 -0700 (PDT) +Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU + [18.9.25.13]) + by olra.theworths.org (Postfix) with ESMTP id A6993431FAE + for ; Wed, 14 Mar 2012 15:16:03 -0700 (PDT) +X-AuditID: 1209190d-b7fbf6d0000008ba-65-4f6118a34c69 +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP + id 82.C6.02234.3A8116F4; Wed, 14 Mar 2012 18:16:03 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q2EMG2N5026345; + Wed, 14 Mar 2012 18:16:03 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2EMG1k4001111 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 14 Mar 2012 18:16:02 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1S7wUD-0000tZ-7r; Wed, 14 Mar 2012 18:16:01 -0400 +Date: Wed, 14 Mar 2012 18:16:01 -0400 +From: Austin Clements +To: David Bremner +Subject: Re: Patches for 0.12 +Message-ID: <20120314221601.GN2787@mit.edu> +References: <87k42stuno.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87k42stuno.fsf@zancas.localnet> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYrdT0V0skehv8LBX1OJGazejxfWbM5kd + mDyerbrF7LHl0HvmAKYoLpuU1JzMstQifbsEroy1R2cwFRzhq9h6/SFjA+ML7i5GTg4JAROJ + 7WtXMUHYYhIX7q1n62Lk4hAS2Mco0fX/IpSzgVHi5PG1zBDOSSaJGc19rBDOEkaJjtu72bsY + OThYBFQl9p8IARnFJqAhsW3/ckYQWwQofHXbZDYQm1lAWuLb72YmkHJhAVmJR5vCQcK8AtoS + b++2sILYQgI6Esee97BBxAUlTs58wgLRqiVx499LsFaQMcv/cYCEOQV0Jea8nsMMYosKqEhM + ObmNbQKj0Cwk3bOQdM9C6F7AyLyKUTYlt0o3NzEzpzg1Wbc4OTEvL7VI10gvN7NELzWldBMj + KKg5JXl3ML47qHSIUYCDUYmHN6s+3l+INbGsuDL3EKMkB5OSKG+VeKK/EF9SfkplRmJxRnxR + aU5q8SFGCQ5mJRFeUy6gHG9KYmVValE+TEqag0VJnFdV652fkEB6YklqdmpqQWoRTFaGg0NJ + grdBFKhRsCg1PbUiLTOnBCHNxMEJMpwHaDifCMjw4oLE3OLMdIj8KUZFKXFeV5CLBEASGaV5 + cL2wpPOKURzoFWHefJAqHmDCgut+BTSYCWhwybc4kMEliQgpqQZGyx3T9p9LVfu38OjewIK4 + fDumQz8al+f94433OzZ38VXDEMFTy/NybA/Punv9VZafs69jTEv74y3fWma3XX/89K/GAfXk + 9e/tZ/OJej2otre8/zhr/qPF/q/4QsI8bvYfEVixk9EupLYzVjSh9GaUz+/N997v2rowIvHb + BO+ibf8WTtySPO+ChhJLcUaioRZzUXEiAIux0TIVAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 14 Mar 2012 22:16:04 -0000 + +Quoth David Bremner on Mar 10 at 10:09 am: +> +> As usual, nothing brings out the bug reports like a freeze. +> +> There are some patches that should probably go in, but could use one +> more pair of eyes. +> +> id:"1330849538-24558-1-git-send-email-jani@nikula.org" + +I looked at this and just sent a question to Jani + id:"87k42momyi.fsf@awakening.csail.mit.edu" +If the answer is that it's okay, then consider my eyes one more pair. + +> We had a somewhat lively debate about desirablity of the following +> patch. My decision is that for now, we avoid changing the behaviour of +> notmuch, and do apply the patch. We can discuss later deprecating or +> changing this permissive behaviour. +> +> id:"1331385931-1610-1-git-send-email-david@tethera.net" + +Alternatively, can we just require GMime 2.6.7 by applying + id:"1331515786-485-1-git-send-email-david@tethera.net" +instead of + id:"1331385931-1610-1-git-send-email-david@tethera.net" +and + id:"1329852935-3019-1-git-send-email-schnouki@schnouki.net" +? + +> This patch from Austin seems innocent enough, and I plan to push it to +> release. +> +> id:"1331058417-13776-1-git-send-email-amdragon@mit.edu" + +The worst-case scenario with applying this patch is that notmuch will +verbosely fail to show a message where it would otherwise crash, so +I'd go for it. + +> I'm not sure about including +> +> id:"1329852935-3019-1-git-send-email-schnouki@schnouki.net" +> +> it wouldn't really help debian (as the unstable buildds already have +> 2.6.6), but I guess it might help others building debian packages. + +(See my comment about 2.6.7 above.) + +> Although +> +> id:"1331225101-24385-1-git-send-email-jrollins@finestructure.net" +> +> is marked as trivial and is certainly short, I'd like one more pair of +> eyes before pushing to release. + +I approve this patch. -- 2.26.2