From 32df202bc7449ce887629cfb97379f3d49dbbfd2 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sat, 1 Dec 2012 01:23:26 +0200 Subject: [PATCH] Re: [Patch v2 06/17] test: add broken roundtrip test --- 80/20d9492d2abadeff0ca21ea0d923b3681fa92c | 115 ++++++++++++++++++++++ 1 file changed, 115 insertions(+) create mode 100644 80/20d9492d2abadeff0ca21ea0d923b3681fa92c diff --git a/80/20d9492d2abadeff0ca21ea0d923b3681fa92c b/80/20d9492d2abadeff0ca21ea0d923b3681fa92c new file mode 100644 index 000000000..5bec72152 --- /dev/null +++ b/80/20d9492d2abadeff0ca21ea0d923b3681fa92c @@ -0,0 +1,115 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 35BEC431FAF + for ; Fri, 30 Nov 2012 15:23:32 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 1q5I4TBIRiak for ; + Fri, 30 Nov 2012 15:23:31 -0800 (PST) +Received: from mail-la0-f53.google.com (mail-la0-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6AB88431FAE + for ; Fri, 30 Nov 2012 15:23:31 -0800 (PST) +Received: by mail-la0-f53.google.com with SMTP id w12so847393lag.26 + for ; Fri, 30 Nov 2012 15:23:29 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=91kXxrDVmQX+3CoauYPsnNHloimzFb+wveSp080yIR8=; + b=TUfIDO89w8M0M8h1QavmxGjrshcta2cdvh0cZuPE/uPZcNYFDNGKx2oJLmtE+Qa7j4 + LXTsMq0CcfBxw3sFLis8zheA53IRSF8r5odPpDElfkGZv1AkM3oPqGECxu1RnTEmnbph + zxBimv1ze6JiCLd10fZJ+vwQwwZtyh2U+uyDQ5V+8seSgP5WoS1B7UIqA4AIkUw1vHEA + JB6FO2SNXe8YJAbxekafKw8ZKYVF+YdA6v54csKVlVNU9uWgOJr49djkPStWiGd17AYJ + IoBhVrvI6hhM+5VwW8YuHclhk5BwLtHirnhEsjIwi7ecvqcR7Ga3BbxGYgLWcBqmCGJ1 + RR1A== +Received: by 10.112.10.3 with SMTP id e3mr1520274lbb.33.1354317809682; + Fri, 30 Nov 2012 15:23:29 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id v6sm2575951lbf.11.2012.11.30.15.23.27 + (version=SSLv3 cipher=OTHER); Fri, 30 Nov 2012 15:23:28 -0800 (PST) +From: Jani Nikula +To: david@tethera.net, notmuch@notmuchmail.org +Subject: Re: [Patch v2 06/17] test: add broken roundtrip test +In-Reply-To: <1353792017-31459-7-git-send-email-david@tethera.net> +References: <1353792017-31459-1-git-send-email-david@tethera.net> + <1353792017-31459-7-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.14+124~g3b17402 (http://notmuchmail.org) Emacs/23.4.1 + (i686-pc-linux-gnu) +Date: Sat, 01 Dec 2012 01:23:26 +0200 +Message-ID: <87lidiad5d.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQm1HJoybyKl0aU2wJZ606wHpoFow1rmhAatv5ppqVdU/a2PUPUwqVWoACWLOmab2DCvtk84 +Cc: David Bremner +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 30 Nov 2012 23:23:32 -0000 + +On Sat, 24 Nov 2012, david@tethera.net wrote: +> From: David Bremner +> +> We demonstrate the current notmuch restore parser being confused by +> message-id's and tags containing non alpha numeric characters +> (particularly space and parentheses are problematic because they are +> not escaped by notmuch dump). +> +> We save the files as hex escaped on disk so that the output from the +> failing test will not confuse the terminal emulator of people running +> the test. + +Theoretically this could pass without failing just fine. ;) + +LGTM, +Jani. + +> --- +> test/dump-restore | 9 +++++++++ +> 1 file changed, 9 insertions(+) +> +> diff --git a/test/dump-restore b/test/dump-restore +> index b05399c..a2204fb 100755 +> --- a/test/dump-restore +> +++ b/test/dump-restore +> @@ -85,4 +85,13 @@ test_begin_subtest "dump --output=outfile -- from:cworth" +> notmuch dump --output=dump-outfile-dash-inbox.actual -- from:cworth +> test_expect_equal_file dump-cworth.expected dump-outfile-dash-inbox.actual +> +> +test_expect_success 'roundtripping random message-ids and tags' \ +> + 'test_subtest_known_broken && +> + ${TEST_DIRECTORY}/random-corpus --num-messages=10 --config-path=${NOTMUCH_CONFIG} && +> + notmuch dump | ${TEST_DIRECTORY}/hex-xcode --direction=encode > EXPECTED.$test_count && +> + notmuch tag -random-corpus tag:random-corpus && +> + ${TEST_DIRECTORY}/hex-xcode --direction=decode < EXPECTED.$test_count | notmuch restore 2>/dev/null && +> + notmuch dump | ${TEST_DIRECTORY}/hex-xcode --direction=encode > OUTPUT.$test_count && +> + test_cmp EXPECTED.$test_count OUTPUT.$test_count' +> + +> test_done +> -- +> 1.7.10.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2