From 32cbce4a9828b52d9e0a00e4fb96819a2c6713ab Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Sun, 15 Jul 2012 14:13:11 +1700 Subject: [PATCH] Re: [PATCH v2 4/7] emacs: Use result text properties for search result iteration --- 02/84f89d57816296b327e0f1383ef28b4c7c3ce1 | 123 ++++++++++++++++++++++ 1 file changed, 123 insertions(+) create mode 100644 02/84f89d57816296b327e0f1383ef28b4c7c3ce1 diff --git a/02/84f89d57816296b327e0f1383ef28b4c7c3ce1 b/02/84f89d57816296b327e0f1383ef28b4c7c3ce1 new file mode 100644 index 000000000..c6a23124f --- /dev/null +++ b/02/84f89d57816296b327e0f1383ef28b4c7c3ce1 @@ -0,0 +1,123 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 11183431FBD + for ; Sat, 14 Jul 2012 14:13:23 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fOPRzwQw4avJ for ; + Sat, 14 Jul 2012 14:13:21 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 2F7AF431FBC + for ; Sat, 14 Jul 2012 14:13:21 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id C4C2166E0024; + Sat, 14 Jul 2012 14:13:20 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.192.57]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id D981B66E00CC; + Sat, 14 Jul 2012 14:13:13 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 64AF443B; Sat, 14 Jul 2012 14:13:13 -0700 (PDT) +From: Jameson Graef Rollins +To: Austin Clements +Subject: Re: [PATCH v2 4/7] emacs: Use result text properties for search + result iteration +In-Reply-To: <20120714195003.GF31670@mit.edu> +References: <1342140319-19859-1-git-send-email-amdragon@mit.edu> + <1342237406-32507-1-git-send-email-amdragon@mit.edu> + <1342237406-32507-5-git-send-email-amdragon@mit.edu> + <87d33yf8bi.fsf@servo.finestructure.net> + <20120714195003.GF31670@mit.edu> +User-Agent: Notmuch/0.13.2+89~g9ab91ad (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 14 Jul 2012 14:13:11 -0700 +Message-ID: <874npaqc60.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 14 Jul 2012 21:13:23 -0000 + +--=-=-= + +On Sat, Jul 14 2012, Austin Clements wrote: +> That's strange. What was the error? +> +> I've been testing with +> (("date" . "%12s ") +> ("count" . "%-7s ") +> ("authors" . "%-20s ") +> ("subject" . "\n%s ") +> ("tags" . "(%s)")) +> But maybe there are other cases it doesn't handle correctly? + +Hrm. The error was: + + error in process filter: wrong type argument: wholenump, -13 + +However, that's in my test emacs setup. It works fine in my normal +emacs session. Lets assume this is just a problem with my setup that +I'll look into. + +The other problem I seem to be running into is that the +customize-variable interface definitely doesn't handle newlines very +well. If I try to add a '\n' in the interface it gets escaped, so I end +up with: + + ("subject" . "\\n%s ") + +If I add the '\n' manually in my config, notmuch-search then interprets +the string correctly and adds newlines to the search results, but then +the customize-variable interface interprets the newline and adds a +newline the string field that kind makes the interface a little weird. +Is there "proper" way to add a newline to a string value in the +customize-variable interface that I'm not aware of? + +In any event, this is in no way a blocker for this patch series. This +is all totally tangential. The patch series is great. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJQAeDnAAoJEO00zqvie6q8aM0QAKi9MurNLAj271zbyBpiMQXX +CE7VUEEfZVzD4xk/knTM5vCPurfqizqjiictSb7DEqHVjwtf3ypANgK4AC4NM6FB +LOxZ3+WMnkO6s0wCbvz4P4BnGt4NhLZnqLQsdZ0igJbOeD7efRolxR1tEp6y+6H1 +JM8KjaJECTj3fjGceN83vXoBZBpJm6+/6FmvPRnM+1KfMEzEYxeq0kntarvX0fVP +TJsgYIDexWsGdEWQ6gaBD+7EtB4fVwpPome3LQF8LqjcBmBT8QVveMy776h1Jhih +4VMKTf6QBEEGU2LBp8VfIbej+Eb0/LgnkaBSg8WrdnR9VX7clZifRcVu+NZTWYpf +KTlBy4jOQe3eSx43W2BlgPmEU9S1kNvHPLJs4LGgsvo2fI8G3kVVHrrEjF2HwtIu +Z8hEnopFDmssXZzfSgyy79FVHMsb9ESNbKshiZEHEKxn1BbF9aPiTlWj7jnUeRdE +paHHDDeWFknQvNOlU/5G6i17xpmMz+nSZ20kIg/VOMFH2mOm7LQJUgiN2/l3M9Ky +KlZ8eam6RJCDMqEjBDmEnF3O2Tn3RU+OAucXO2YYb8KcOOaPbn9gctznxwBzl7ll +W2dGRk3n1xf3zYKdmNE/WMlHjbtb7O5KBZrp63ZfRcFbARWBmEp4V4apTi4qqZA8 +YswBM/e/D9Z6oXmMw1zZ +=Tgpu +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2