From 31d09e1e3e55b461a79d00ad4400da565da302df Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 3 Jun 2012 18:07:11 +0300 Subject: [PATCH] Re: [PATCH] config: add quoting to fix IFS bug --- d6/ef25f44a992bcd3d7db39b0f44ad10e6f0e5ee | 88 +++++++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 d6/ef25f44a992bcd3d7db39b0f44ad10e6f0e5ee diff --git a/d6/ef25f44a992bcd3d7db39b0f44ad10e6f0e5ee b/d6/ef25f44a992bcd3d7db39b0f44ad10e6f0e5ee new file mode 100644 index 000000000..67c32f087 --- /dev/null +++ b/d6/ef25f44a992bcd3d7db39b0f44ad10e6f0e5ee @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7CA9D431FB6 + for ; Sun, 3 Jun 2012 08:07:02 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id E6PkJ0LIRDw0 for ; + Sun, 3 Jun 2012 08:07:01 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id BE13C431FAF + for ; Sun, 3 Jun 2012 08:07:01 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 51F5510014D; Sun, 3 Jun 2012 18:07:11 +0300 (EEST) +From: Tomi Ollila +To: Jameson Graef Rollins , + Notmuch Mail +Subject: Re: [PATCH] config: add quoting to fix IFS bug +In-Reply-To: <1338660961-13760-1-git-send-email-jrollins@finestructure.net> +References: <1338660961-13760-1-git-send-email-jrollins@finestructure.net> +User-Agent: Notmuch/0.13+29~g3c353b7 (http://notmuchmail.org) Emacs/23.1.1 + (x86_64-redhat-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 03 Jun 2012 15:07:02 -0000 + +On Sat, Jun 02 2012, Jameson Graef Rollins wrote: + +> Without proper quoting the DEFAULT_IFS was getting set incorrectly, +> which was causing problems with the storage of some variables later in +> the script. Quoting fixes the problem. + +LGTM + +Tomi + + +> --- +> Thanks to Tomi for the inspiration for this fix. I don't know how I +> missed such a simple solution initially. +> +> configure | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/configure b/configure +> index 5602be2..3fad424 100755 +> --- a/configure +> +++ b/configure +> @@ -1,7 +1,7 @@ +> #! /bin/sh +> +> # Store original IFS value so it can be changed (and restored) in many places. +> -readonly DEFAULT_IFS=$IFS +> +readonly DEFAULT_IFS="$IFS" +> +> srcdir=$(dirname "$0") +> +> -- +> 1.7.10 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2