From 2d85af3b4ec576d4d16507f001765c4f1439384a Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sat, 24 Mar 2012 21:49:36 +0000 Subject: [PATCH] Reply code with TEXT/PLAIN --- 55/78531cac9e56d2ecbab42719be49aa73dd877d | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 55/78531cac9e56d2ecbab42719be49aa73dd877d diff --git a/55/78531cac9e56d2ecbab42719be49aa73dd877d b/55/78531cac9e56d2ecbab42719be49aa73dd877d new file mode 100644 index 000000000..488c8aba6 --- /dev/null +++ b/55/78531cac9e56d2ecbab42719be49aa73dd877d @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5D89F431FAF + for ; Sat, 24 Mar 2012 14:49:26 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id H3G1b1O2OkJz for ; + Sat, 24 Mar 2012 14:49:26 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E2E1C431FAE + for ; Sat, 24 Mar 2012 14:49:25 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SBYpw-000077-8O; Sat, 24 Mar 2012 21:49:24 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SBYpv-0006qZ-Pd; Sat, 24 Mar 2012 21:49:23 +0000 +From: Mark Walters +To: Adam Wolfe Gordon , notmuch@notmuchmail.org +Subject: Reply code with TEXT/PLAIN +User-Agent: Notmuch/0.12+65~g8bf1842 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 24 Mar 2012 21:49:36 +0000 +Message-ID: <87d3814qkv.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 81184fa3cf15241b16be16260c7c8c4d (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 24 Mar 2012 21:49:26 -0000 + + + +I am not certain if this is a bug or a request to work around broken +mailers. I tried replying to a message today (with recent git) and got +an empty message. I looked at the json output for reply and it contains +the message but the content type is TEXT/PLAIN rather than +text/plain. + +This seems to mean it doesn't match in notmuch-match-content-type +(notmuch-lib.el) called from notmuch-mua-get-quotable-parts (in +notmuch-mua.el); and so does not get included. + +Making the match case-insensitive `fixed' the problem. + +I don't know whether content-types are allowed to be upper-case but I +seem to have several mails where they are. I am also not sure whether +the correct fix is in the emacs code, or in the cli reply format +(i.e. perhaps the reply format should lower-case the content-type). + +Best wishes + +Mark + +PS Sorry Adam for the duplicate: I sent from a wrong address (my fault +this time)! -- 2.26.2