From 2d0712fc89f50f6e5351705d699842c25de7c8d7 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Thu, 24 May 2012 22:22:16 +2100 Subject: [PATCH] Re: [PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one --- a6/f7d18de3a4a3cda569b140485c665f3a79e6c7 | 82 +++++++++++++++++++++++ 1 file changed, 82 insertions(+) create mode 100644 a6/f7d18de3a4a3cda569b140485c665f3a79e6c7 diff --git a/a6/f7d18de3a4a3cda569b140485c665f3a79e6c7 b/a6/f7d18de3a4a3cda569b140485c665f3a79e6c7 new file mode 100644 index 000000000..5d9d2675d --- /dev/null +++ b/a6/f7d18de3a4a3cda569b140485c665f3a79e6c7 @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B8717431FC3 + for ; Wed, 23 May 2012 18:22:32 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QgyOk4BZpdGD for ; + Wed, 23 May 2012 18:22:29 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5A2A2431FBD + for ; Wed, 23 May 2012 18:22:29 -0700 (PDT) +Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.89.108] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) + (Exim 4.72) (envelope-from ) + id 1SXMkw-0006gs-HM; Wed, 23 May 2012 22:22:22 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.77) + (envelope-from ) + id 1SXMkq-0005Ke-N2; Wed, 23 May 2012 22:22:16 -0300 +From: David Bremner +To: Felipe Contreras , + Ali Polatel +Subject: Re: [PATCH 3/4] ruby: Add workarounds to use in-tree build not the + installed one +In-Reply-To: + +References: <87txzsgs4g.fsf@zancas.localnet> + + <1559639bc5e9e3253f2ee2220a8d8d00c39d9d43.1336402558.git.alip@exherbo.org> + +User-Agent: Notmuch/0.13 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 23 May 2012 22:22:16 -0300 +Message-ID: <878vgi1ign.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Spam_bar: - +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 24 May 2012 01:22:32 -0000 + +Felipe Contreras writes: + + +> I don't see how this patch could be fixed properly easily, and it was +> labeled as a hack, and I didn't like it in the first place anyway, so +> I'm going to revert it by tomorrow if I don't hear any good reason not +> to. + +I think this highlights the need for at least a minimal test suite for +the ruby + +I do plan on a bug fix release, to fix an annoying emacs interface bug +if nothing else. I'd rather see a fix/revert coordinated with Ali in his +role as ruby bindings maintainer. + +FWIW, the previous situation of linking with the installed version of +notmuch sounds somewhat broken as well, although obviously preferable to +not working at all. + +d -- 2.26.2