From 2c05be8002c93e8b4e61121303517020fee342b4 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 24 Mar 2012 11:07:22 +0200 Subject: [PATCH] Re: [RFC] Split notmuch_database_close into two functions --- 32/8f46a67ef933a791ff6fdc942aeb34278f23f0 | 72 +++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 32/8f46a67ef933a791ff6fdc942aeb34278f23f0 diff --git a/32/8f46a67ef933a791ff6fdc942aeb34278f23f0 b/32/8f46a67ef933a791ff6fdc942aeb34278f23f0 new file mode 100644 index 000000000..4a148410a --- /dev/null +++ b/32/8f46a67ef933a791ff6fdc942aeb34278f23f0 @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B103F431FAF + for ; Sat, 24 Mar 2012 02:07:24 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id DCwLeCnCjecW for ; + Sat, 24 Mar 2012 02:07:24 -0700 (PDT) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id 27A9E431FAE + for ; Sat, 24 Mar 2012 02:07:24 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 26E9768055; Sat, 24 Mar 2012 11:07:22 +0200 (EET) +From: Tomi Ollila +To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org +Subject: Re: [RFC] Split notmuch_database_close into two functions +In-Reply-To: + <1332291311-28954-1-git-send-email-4winter@informatik.uni-hamburg.de> +References: <1332291311-28954-1-git-send-email-4winter@informatik.uni-hamburg.de>User-Agent: Notmuch/0.12+70~g598bf0a (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 24 Mar 2012 09:07:24 -0000 + +Justus Winter <4winter@informatik.uni-hamburg.de> writes: + +> I propose to split the function notmuch_database_close into +> notmuch_database_close and notmuch_database_destroy so that long +> running processes like alot can close the database while still using +> data obtained from queries to that database. +> +> I've updated the tools, the go, ruby and python bindings to use +> notmuch_database_destroy instead of notmuch_database_close to destroy +> database objects. + +This looks like a good idea. grep _destroy *.c outputs plenty of +other matches so this is not a new term here. I wonder what (backward) +compability issues there are, though. + +In message id:"1332291311-28954-2-git-send-email-4winter@informatik.uni-hamburg.de" +there was typo in comment: notmuch_database_destroyed ? + +> +> Cheers, +> Justus + +Tomi -- 2.26.2