From 2bef3baa1567a465489ae6a867fede27dda17bd6 Mon Sep 17 00:00:00 2001 From: Daniel Schoepe Date: Sun, 12 Feb 2012 15:31:46 +0100 Subject: [PATCH] Re: RFC notmuch-pick: an emacs threaded message view with split-pane --- 54/1a718e5745029c94d71df84c76a685826f1f3c | 149 ++++++++++++++++++++++ 1 file changed, 149 insertions(+) create mode 100644 54/1a718e5745029c94d71df84c76a685826f1f3c diff --git a/54/1a718e5745029c94d71df84c76a685826f1f3c b/54/1a718e5745029c94d71df84c76a685826f1f3c new file mode 100644 index 000000000..e136c67ef --- /dev/null +++ b/54/1a718e5745029c94d71df84c76a685826f1f3c @@ -0,0 +1,149 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id DE9B6431FB6 + for ; Sun, 12 Feb 2012 06:32:00 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.8 +X-Spam-Level: +X-Spam-Status: No, score=-0.8 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 94fqzEFsTMEl for ; + Sun, 12 Feb 2012 06:31:59 -0800 (PST) +Received: from mail-ey0-f181.google.com (mail-ey0-f181.google.com + [209.85.215.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A7A38431FAE + for ; Sun, 12 Feb 2012 06:31:59 -0800 (PST) +Received: by eaak14 with SMTP id k14so2126823eaa.26 + for ; Sun, 12 Feb 2012 06:31:57 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=zrmFGdaiEosfW50ta3fH19vEaOGxA0p8SiaAowGgkEQ=; + b=YFnG8wWQKhH/0dwSHoJsXy+zRPmV9xCI4vjMGKGhEpWbLAOPjNTYLAmei2g/WkW/kd + ZRx4DgtUeEYg6O6o5hkU3c+CIwUx4iso8PSViUksrDhlkSROt/TgeDhbLyC5GvwhkNYg + cGWY0RN3bN2LOb3DkgwS9JKWuK7iBV5assxyo= +Received: by 10.213.19.130 with SMTP id a2mr2216711ebb.148.1329057116835; + Sun, 12 Feb 2012 06:31:56 -0800 (PST) +Received: from localhost (dslb-088-069-141-163.pools.arcor-ip.net. + [88.69.141.163]) + by mx.google.com with ESMTPS id o49sm49321230eei.0.2012.02.12.06.31.55 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 12 Feb 2012 06:31:56 -0800 (PST) +From: Daniel Schoepe +To: +Subject: Re: RFC notmuch-pick: an emacs threaded message view with split-pane +In-Reply-To: <87d39k1gvi.fsf@qmul.ac.uk> +References: <87d39k1gvi.fsf@qmul.ac.uk> <87ehu0cf16.fsf@schoepe.localhost> +User-Agent: Notmuch/0.11.1+180~g5d5a693 (http://notmuchmail.org) + Emacs/24.0.93.1 (x86_64-pc-linux-gnu) +Date: Sun, 12 Feb 2012 15:31:46 +0100 +Message-ID: <878vk8cect.fsf@schoepe.localhost> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-Gm-Message-State: + ALoCoQnMIN2MzK65/myX2KHPNVkSuMwBwWCoZtfHTXOUNdo7t/Jb9o0LZfSRGD6y3IyKZFPgyL3F +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 12 Feb 2012 14:32:01 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +Forgot to reply to the list.... + +On Sun, 12 Feb 2012 10:32:48 +0000, Mark Walters wrote: +> Questions/thoughts and known bugs: +>=20 +> Do people like the rough idea?=20 + +I think it's a great idea. What I find especially nice about this, is +that it works for both, just showing the structure of one thread and the +traditional all-messages-matching-a-search view. I've actually rebound + in notmuch-search to this and it works great so far: + +(defun notmuch-search-pick () + "Show the selected thread with notmuch-pick" + (interactive) + (notmuch-pick (notmuch-search-find-thread-id) + notmuch-search-query-string + (notmuch-prettify-subject (notmuch-search-find-subject))) + (unless (notmuch-pick-get-match) + (notmuch-pick-next-message)) + (notmuch-pick-show-message)) + +> At the moment there is some shared code with notmuch-show.el. This could +> be factored out: however, while this pick mode is WIP I don't think it +> is worth it. I have tried to keep the impact on the current parts of the +> emacs code and the command line interface fairly small. +>=20 +> I will send the patches as 3 bits: one is the command-line support +> needed (i.e. changes to notmuch-show.c) one is the changes to the other +> emacs files and the final one is the notmuch-pick.el file itself. +>=20 +> There are some things that need fixing: some of which are marked in the +> code. For example the highlighting (lowlighting?) of non-matching +> messages is hard-wired gray and should be a defcustom. The tags are not +> in a nice tag face and do not update automatically. There should be an +> option not to use the split-screen mode. + +Yeah, the hardcoded "black" is also pretty annoying if one uses a +black background. :) +I'll send a patch fixing that later. + +> Anyway I am already finding it useful: show a long thread, press 'Z' to +> see the thread structure nicely and then ... + +Yeah, that's basically my main use case, as I don't like dozens of +messages of the same thread cluttering up all the search results +(e.g. for tag:notmuch). + +Thanks for the great work David and Mark, I've really been looking +forward to something that makes my half-baked attempt at thread +outlining [1] obsolete. :) + +[1] id:"1324082126-25404-1-git-send-email-daniel@schoepe.org" + +Cheers, +Daniel + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iQIcBAEBAgAGBQJPN81SAAoJEIaTAtce+Z+JrhwQAI1mwOtkSWFfS3lLM+kSqnBm +C8rT7NVBrDYoKMK4v1xA0AV2nGQl+Qw+fkQlmec4FwmaajJHMSCO2RMXBzIE8kwu +un1LPPeawM051yHq0uquY9CSrBMII3dOxa4qwR6noa+Syd8MBP6bgHFlDCAlpSg4 +ZPyndlJ2vGHAj/cLdAiq3zbO15s8/3F7fYkRCOiP90/fK1aPfco8tTnZy8DcpZw7 +/5mtqeG3BoeJKAoLaIkXcG+u/wPW9RYGst/Th1cbntnLNyfC2lZeVNkh37jxAYMa +lT2dOc3X0UXaqzeowFY0+QJUwVLeItU3XvYluLvtkHc8iVn1JIYBBynEgJNTM0An +pITawmpaQPjCAUF4kYmvw1VvSaHcZwsUzNHtGXUqPPvGnJa9Fgqhx11UpmuMs0Q7 +0971bnLQ6Drh24/I0NNHqC4ZZlY3MJuvFObe95yGkBQ1Pns2BWWDFYdE/VPUimFj +OugITtDIU1QtDuVja1xofh0IwEqnvOmMsr7gbp7FBRY0y+4QLk1bsz2qwh1UWovb +TrfbOY2nQlmMFEx/VoBTx+xbl8rbUrDPAp/QJ3bSnADEAUqgzqOHn+ncS54Wqr7d +9k4VXzYy7ufcMg83hxbb81IXTUgWutJ7Vw/ZuqQrCnDxjuzx3JkebcK1fXcgKCFq +6VnYbl/iTi3trCgdGeu5 +=InYV +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2