From 2b76017def723f4f3a4dc8d469995dc75be1a424 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 6 Jan 2013 16:10:01 +0000 Subject: [PATCH] Re: [PATCH] emacs: show: make id links respect window --- 95/e838d365ec94003ed1d6b1f04d0274d33b59a9 | 184 ++++++++++++++++++++++ 1 file changed, 184 insertions(+) create mode 100644 95/e838d365ec94003ed1d6b1f04d0274d33b59a9 diff --git a/95/e838d365ec94003ed1d6b1f04d0274d33b59a9 b/95/e838d365ec94003ed1d6b1f04d0274d33b59a9 new file mode 100644 index 000000000..7e4bc8899 --- /dev/null +++ b/95/e838d365ec94003ed1d6b1f04d0274d33b59a9 @@ -0,0 +1,184 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 75282431FAF + for ; Sun, 6 Jan 2013 08:10:06 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id u4G33Lk5u7Ha for ; + Sun, 6 Jan 2013 08:10:05 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8444B431FAE + for ; Sun, 6 Jan 2013 08:10:05 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1TrsnO-0006qJ-Nc; Sun, 06 Jan 2013 16:10:01 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1TrsnO-0006Mf-Ci; Sun, 06 Jan 2013 16:09:58 +0000 +From: Mark Walters +To: Tomi Ollila , David Bremner , + notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: show: make id links respect window +In-Reply-To: +References: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com> + <87bodjfnt0.fsf@zancas.localnet> <87mwx2jsu0.fsf@qmul.ac.uk> + <87bodgrh6a.fsf@zancas.localnet> + <87k3rqz594.fsf@qmul.ac.uk> + +User-Agent: Notmuch/0.14+236~g1d0044f (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 06 Jan 2013 16:10:01 +0000 +Message-ID: <87hamuz412.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 5cedcd1bdbcb0af0c8303c5a9bf2d650 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 06 Jan 2013 16:10:06 -0000 + + +On Sun, 06 Jan 2013, Tomi Ollila wrote: +> On Sun, Jan 06 2013, Mark Walters wrote: +> +>> On Sat, 05 Jan 2013, Tomi Ollila wrote: +>>> On Wed, Dec 26 2012, David Bremner wrote: +>>> +>>>> Mark Walters writes: +>>>> +>>>>>> I can imagine that people would want/like the "open in other window" +>>>>>> effect of the current code, even if the reason is a bug. +>>>>> +>>>>> That's definitely possible. I generally expect a mouse click to select +>>>>> the window I click and this feels counter intuitive. I think that some +>>>>> people might like an option "open this link in a new window" but I would +>>>>> guess that would like that whether they clicked or pressed RET on the +>>>>> button. +>>>> +>>>> I don't care much either way myself, but before we change notmuch-show +>>>> behaviour (effectively) to accomodate notmuch-pick, I'd like a bit more +>>>> feedback from other people. +>>> +>>> I tested the old behaviour -- split frame to 2 windows, one containing +>>> *scratch* and one *notmuch-hello*. Then I searched for 'obsoletes', +>>> chose last message (id:1356936162-2589-1-git-send-email-amdragon@mit.edu) +>>> moved point to *scratch* buffer and clicked the id: link -- and indeed, +>>> the *scratch* window was replaced. +>>> +>>> I didn't look or test Mark's patch as he stated: +>>> "The lisp is not pretty but seems to work." ;) +>>> ... well, not entirely because of that but I trust it opens the message +>>> in window where the clicked link were and keeps point where it used to +>>> be before clicking (in case point was in different window). +>> +>> It doesn't quite do this: point moves to the window that was clicked. It +>> is just as easy to do as Tomi says (patch below but I should resend if +>> people like it so the commit message gets picked up). +> +> It seems to be the default (and iniuitively expected) behaviour that +> point moves to the window that was clicked... so that's ok :) +> +>> Incidentally, I would be interested to know what people expect the +>> following to do: go to notmuch hello and then search. Now display the +>> results in two windows simultaneously (either split the frame into two +>> windows (c-x 2) or use 2 frames (C-x 5 2)) and then press q. +>> +>> What actually happens is that q runs kill buffer so it disappears in +>> both windows: one of which will fall back to notmuch-hello and one of +>> which will fall back to some other window (eg scratch) +> +> I think that is just expected behaviour, there are e.g.. c-x b and c-x 0 +> which should be familiar to every emacs users... + +My instinct would be that the window I press q in should go to the +previous buffer in that window but the other window should stay where it +was. But if others are happy as it that is obviously fine. + + +>> Best wishes +>> +>> Mark +> +> Tomi +> +> PS: did you change anything in the patch below ? + +Yes: the new version uses (with-selected-window window ...) compared +with (select-window window) (...) + +So the old version switches point to the clicked window, the new version +does not. I am happy either way: the click does normally move point, but +other buttons such as invisibility buttons do not move point when +mouse-clicked so.... + +Best wishes + + +Mark + + +>> +>> emacs/notmuch-show.el | 5 +++++ +>> 1 files changed, 5 insertions(+), 0 deletions(-) +>> +>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +>> index 5751d98..00b9b56 100644 +>> --- a/emacs/notmuch-show.el +>> +++ b/emacs/notmuch-show.el +>> @@ -1077,6 +1077,11 @@ buttons for a corresponding notmuch search." +>> (make-text-button (first link) (second link) +>> 'action `(lambda (arg) +>> (notmuch-show ,(third link))) +>> + 'mouse-action `(lambda (arg) +>> + (let* ((event last-input-event) +>> + (window (car (cadr event)))) +>> + (with-selected-window window +>> + (notmuch-show ,(third link))))) +>> 'follow-link t +>> 'help-echo "Mouse-1, RET: search for this message" +>> 'face goto-address-mail-face))))) +>> -- +>> 1.7.9.1 +>> +>> _______________________________________________ +>> notmuch mailing list +>> notmuch@notmuchmail.org +>> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2