From 2a9d33e33a2302d893d3631d6e227c17f4c19741 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Sat, 19 May 2012 12:17:49 +1700 Subject: [PATCH] Re: [PATCH v2 3/5] cli: modify mime_node_context to use the new notmuch_crypto_t --- 36/627442fa47aad504d978a71c0a1c1948c871a0 | 99 +++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 36/627442fa47aad504d978a71c0a1c1948c871a0 diff --git a/36/627442fa47aad504d978a71c0a1c1948c871a0 b/36/627442fa47aad504d978a71c0a1c1948c871a0 new file mode 100644 index 000000000..aaa4f0aff --- /dev/null +++ b/36/627442fa47aad504d978a71c0a1c1948c871a0 @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 96FD4431FAE + for ; Fri, 18 May 2012 12:18:02 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id puJTolz1bvIV for ; + Fri, 18 May 2012 12:18:00 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 7D35A431FBD + for ; Fri, 18 May 2012 12:17:57 -0700 (PDT) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id 2A2D52E50BD5; + Fri, 18 May 2012 12:17:57 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (rrcs-24-103-26-131.nyc.biz.rr.com + [24.103.26.131]) (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id 506922E50DFC; + Fri, 18 May 2012 12:17:54 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 3BD054AD; Fri, 18 May 2012 12:17:52 -0700 (PDT) +From: Jameson Graef Rollins +To: Austin Clements +Subject: Re: [PATCH v2 3/5] cli: modify mime_node_context to use the new + notmuch_crypto_t +In-Reply-To: <20120518190925.GU11804@mit.edu> +References: <1337362357-31281-1-git-send-email-jrollins@finestructure.net> + <1337362357-31281-2-git-send-email-jrollins@finestructure.net> + <1337362357-31281-3-git-send-email-jrollins@finestructure.net> + <1337362357-31281-4-git-send-email-jrollins@finestructure.net> + <20120518190925.GU11804@mit.edu> +User-Agent: Notmuch/0.12+183~g9d5ff3c (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 18 May 2012 12:17:49 -0700 +Message-ID: <87wr499u3m.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 18 May 2012 19:18:02 -0000 + +--=-=-= + +On Fri, May 18 2012, Austin Clements wrote: +>> - (GMIME_MULTIPART_SIGNED (part), node->ctx->cryptoctx, &err); +>> + (GMIME_MULTIPART_SIGNED (part), node->ctx->crypto.gpgctx, &err); +> +> This should be crypto->gpgctx. + +Weird. Good catch, Austin! But I must admit I'm thoroughly confused. +I tested every stage of this series right before I sent, and sure enough +this patch compiles cleanly and all tests pass. Can anyone explain why? +I don't understand. I'll send a new version of this one patch now +anyway. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJPtqBdAAoJEO00zqvie6q8O/MP/ihaPSKfWHytzM6N/1QrXICr +ktem0YFo4uISK9dj8sGhKZiqOEoOEkn09Q5Lz1vpznMOcaj4SrcrfjKfKHGqriuf +Ogp5Ll6WauI0UWlvMTkxyh3mLQq78vxzf6F2ivkR8C+hBgT88MPLoDl+CGA2Nt4S +whJLGPf9Zq5HmtxPlqbBcMsSMzQn6C7bb1iFE/tTOj2ORpkWkX5SsCmIuF+GdcSZ +RLu3Rr0UCaFbK8hhLK0pRRLB0EtiMx8EBEPLofDnvYyOe+JGEjsXIpTeNXRGT/7i +pzsWJpUpu3wj+pNQjWmijIEuuwDq4iY0h0Dvxswl9OlZhAKdNcf9GOtSjmjseOB6 +CzIHXKgkUHzM9SIAGSzmQIiUGYGNKogA/6+u9H7zVdYn6MTt/yHKpJ1jNVWT2B/E +0oh3D6FmVOGEto09L9kiJGZ+eJLaeMQ9yJFKLPPu/Rv9hcItdeuQ1MteUnFpqpXh +qCljLK1Kb+Cr7Am+kGOTYjZw5M1XhsFz8l4CVN3CtLnWs0SFApE7YuO89mhuLmMc +ULuhN/apP27CYmJkioaTZkSw+oFtwhROM3YkpJXEidId0T9lcm2wl2EXldT6qR9P +xkf970yd27NXh/WuYIh1CJ3WinlGxqYl6Apihj+Vo/V8kG1va0QsWCRQK/i7T3XM +2y3gVOlx8p9AvEoXc8Oh +=RBIl +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2