From 28cc230ee591c9786a3e2540f8e0f31c21004cff Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Tue, 21 Feb 2012 18:49:01 +0200 Subject: [PATCH] Re: [PATCH] Update crypto test for gmime 2.6.5 --- 61/8e454001e59364f7de9214afeb0d0b963e5b43 | 82 +++++++++++++++++++++++ 1 file changed, 82 insertions(+) create mode 100644 61/8e454001e59364f7de9214afeb0d0b963e5b43 diff --git a/61/8e454001e59364f7de9214afeb0d0b963e5b43 b/61/8e454001e59364f7de9214afeb0d0b963e5b43 new file mode 100644 index 000000000..8b2d79136 --- /dev/null +++ b/61/8e454001e59364f7de9214afeb0d0b963e5b43 @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 74AB9431FAF + for ; Tue, 21 Feb 2012 08:49:04 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id JLlcpVrtdDNj for ; + Tue, 21 Feb 2012 08:49:00 -0800 (PST) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id 9890B431FAE + for ; Tue, 21 Feb 2012 08:49:00 -0800 (PST) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 358C368055; Tue, 21 Feb 2012 18:49:01 +0200 (EET) +From: Tomi Ollila +To: Thomas Jost , notmuch@notmuchmail.org +Subject: Re: [PATCH] Update crypto test for gmime 2.6.5 +In-Reply-To: <1329840343-10026-1-git-send-email-schnouki@schnouki.net> +References: <1329840343-10026-1-git-send-email-schnouki@schnouki.net> +User-Agent: Notmuch/0.11.1+198~g922c4d2 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 21 Feb 2012 16:49:04 -0000 + +On Tue, 21 Feb 2012 17:05:43 +0100, Thomas Jost wrote: +> gmime 2.6 had a bug [1] which made it impossible to tell why a signature +> verification failed when the signer key was unavailable (empty "sigstatus" field +> in the JSON output). Since 00b5623d the corresponding test is marked as broken +> when using gmime 2.6 (2.4 is fine). +> +> The bug has been fixed in gmime 2.6.5. Consequently, the crypto test needs to be +> adjusted so that it is only marked broken for gmime 2.6.4 and below. +> +> [1] https://bugzilla.gnome.org/show_bug.cgi?id=668085 +> --- +> +> Hello world, +> +> Here's a little update about gmime 2.6. The latest version (2.6.5) +> fixes the little regression introduced in 2.6. +> +> In all honesty, I'm not sure adding such a workaround in the test +> suite is worth the effort. If gmime 2.6.5 is quickly packaged by major +> distros (it's already in Arch), we could as well make notmuch depend +> on gmime >= 2.6.5. (One line to change in configure). Or we could just +> stop trying to mark the test as broken and let it fail for buggy +> versions of gmime. +> +> What do you think? + +I'm in favor of gmime >= 2.6.5 requirement. + +> +> Best regards, +> Thomas + +Tomi -- 2.26.2