From 27c97fd693618d6ae08b60fb9b23b8bb904e33ca Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 18 Oct 2012 16:59:20 +0300 Subject: [PATCH] Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' --- 60/26c3f16237d94f1614fe79c394ca959ce73f36 | 87 +++++++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 60/26c3f16237d94f1614fe79c394ca959ce73f36 diff --git a/60/26c3f16237d94f1614fe79c394ca959ce73f36 b/60/26c3f16237d94f1614fe79c394ca959ce73f36 new file mode 100644 index 000000000..ec0b1f5c3 --- /dev/null +++ b/60/26c3f16237d94f1614fe79c394ca959ce73f36 @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C96A7431FBF + for ; Thu, 18 Oct 2012 06:59:18 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id rmzZdCDqmhLD for ; + Thu, 18 Oct 2012 06:59:18 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 05A25431FB6 + for ; Thu, 18 Oct 2012 06:59:17 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id AB19D1000E5; + Thu, 18 Oct 2012 16:59:20 +0300 (EEST) +From: Tomi Ollila +To: Ethan +Subject: Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to + `notmuch-show-toggle-visibility-headers' +In-Reply-To: + +References: <1327469139-1968-1-git-send-email-pieter@praet.org> + <1329936214-30959-3-git-send-email-pieter@praet.org> + <87k3uv9xuo.fsf@betacantrips.com> <877gqo8vx2.fsf@betacantrips.com> + + +User-Agent: Notmuch/0.14+51~g62cd13b (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: Notmuch Mail , Pieter Praet +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 18 Oct 2012 13:59:19 -0000 + +On Thu, Oct 18 2012, Ethan wrote: + +> On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila wrote: +> +>> On Thu, Oct 18 2012, Ethan Glasser-Camp wrote: +>> +>> > Ethan Glasser-Camp writes: +>> > +>> >> This patch, and its predecessors, all look great to me. +>> > +>> > But a note: many of the first lines in your commit messages ("{show, +>> +>> Hmm, first lines -- IIRC mailman adds those tabs to the subject line -- and +>> those are converted to spaces in git-am (??) +>> +> +> I guess this is called "line folding" and notmuch should be sure to undo +> it, as I guess git-am already does. +> +> https://bugs.launchpad.net/mailman/+bug/265915 +> +> I guess I can stop complaining about it ;) Patches 1-3 are probably ready +> then. Thanks, Tomi. + +Np. Tests pass and the function name change is trivial. +Removed needs-review on these 3 patches. + +> Ethan + +Tomi -- 2.26.2