From 24967b480e580bb7832c0393a8528bc2780c2a88 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 31 Mar 2013 12:27:51 +0300 Subject: [PATCH] Re: [PATCH v2 0/3] cli: clean up gmime 2.4 vs. 2.6 conditional build --- 03/ac54e272950c5045fdc1d3e7d7b99d06cea8c3 | 140 ++++++++++++++++++++++ 1 file changed, 140 insertions(+) create mode 100644 03/ac54e272950c5045fdc1d3e7d7b99d06cea8c3 diff --git a/03/ac54e272950c5045fdc1d3e7d7b99d06cea8c3 b/03/ac54e272950c5045fdc1d3e7d7b99d06cea8c3 new file mode 100644 index 000000000..ff90a664a --- /dev/null +++ b/03/ac54e272950c5045fdc1d3e7d7b99d06cea8c3 @@ -0,0 +1,140 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3C61D431FBF + for ; Sun, 31 Mar 2013 02:27:54 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 7+hJ9xTYSlBy for ; + Sun, 31 Mar 2013 02:27:52 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 5E053431FAE + for ; Sun, 31 Mar 2013 02:27:52 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 4A737100086; + Sun, 31 Mar 2013 12:27:51 +0300 (EEST) +From: Tomi Ollila +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/3] cli: clean up gmime 2.4 vs. 2.6 conditional build +In-Reply-To: +References: + +User-Agent: Notmuch/0.15.2+50~g43fdda5 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 31 Mar 2013 09:27:54 -0000 + +On Sun, Mar 31 2013, Tomi Ollila wrote: + +> On Sat, Mar 30 2013, Jani Nikula wrote: +> +>> This is v2 of [1]. Added comments per David's request, and while at it, +>> added a third patch to conform the existing conditional build in notmuch +>> show to the same style. The whole series should have no functional +>> changes, and thus v2 should have no functional changes since v1. ;) +>> +>> I have not tested this on gmime 2.4. +> +> I have gmime 2.4(.24) on this system. The code compiles and +> exactly the same set of tests pass/fail as without this patch +> (unfortunately this system cannot cope with just some of the +> crypto patches, so I cannot give absolute guarantee: + +Ok, the failure cases below are just those which are changed in +this patch. So I had to dig further... + +... actually this + 'PASS emacs delivery of encrypted message with attachment' +fails to deliver the message. + +After the following change: + +--- a/test/test-lib.sh ++++ b/test/test-lib.sh +@@ -442,7 +442,8 @@ emacs_deliver_message () + + test_emacs \ + "(let ((message-send-mail-function 'message-smtpmail-send-it) +- (smtpmail-smtp-server \"localhost\") ++ (smtpmail-smtp-server 'local) ++ ;;(smtpmail-smtp-server \"localhost\") + (smtpmail-smtp-service \"25025\")) + (notmuch-hello) + (notmuch-mua-mail) + +The failured cases below PASSes. + +(I've stumbled the same problem a few cases before but haven't +figured out a good patch so far...) + +> +> crypto: Testing PGP/MIME signature verification and decryption +> PASS emacs delivery of signed message +> PASS signature verification +> PASS signature verification with full owner trust +> PASS signature verification with signer key unavailable +> PASS emacs delivery of encrypted message with attachment +> FAIL decryption, --format=text +> FAIL decryption, --format=json +> FAIL decryption, --format=json, --part=4 +> FAIL decrypt attachment (--part=5 --format=raw) +> FAIL decryption failure with missing key +> PASS emacs delivery of encrypted + signed message +> FAIL decryption + signature verification +> FAIL reply to encrypted message +> FAIL signature verification with revoked key +> +> anyway, as said, exactly the same set fails without these pathes +> +> The reason for failure is most probably in my system and not something +> w/ notmuch crypto support -- If I run `emacs foo.org.gpg` this just +> hangs waiting me to give passphrase in (invisible?) curses request) +> +> So, bottom line: LGTM. +> +>> BR, +>> Jani. +> +> Tomi +> +> +>> [1] id:a9f12ba474fc51df71e2fd2b7a20a8d101729c6e.1362319765.git.jani@nikula.org +>> +>> Jani Nikula (3): +>> cli: crypto: abstract gpg context creation for clarity +>> cli: mime node: abstract decryption and signature verification +>> cli: conform to same conditional build style as elsewhere in +>> notmuch-show +>> +>> crypto.c | 66 ++++++++++++----- +>> mime-node.c | 218 ++++++++++++++++++++++++++++++++++++-------------------- +>> notmuch-show.c | 46 ++++++------ +>> 3 files changed, 215 insertions(+), 115 deletions(-) +>> +>> -- +>> 1.7.10.4 -- 2.26.2