From 1f848a56f05398f7a3b5008effd84e04a57dec36 Mon Sep 17 00:00:00 2001 From: Dmitry Kurochkin Date: Sun, 5 Feb 2012 23:34:44 +0400 Subject: [PATCH] Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments --- 9f/8a098549243ce4c012df1880e19078e831e4f1 | 78 +++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 9f/8a098549243ce4c012df1880e19078e831e4f1 diff --git a/9f/8a098549243ce4c012df1880e19078e831e4f1 b/9f/8a098549243ce4c012df1880e19078e831e4f1 new file mode 100644 index 000000000..c693b2a5b --- /dev/null +++ b/9f/8a098549243ce4c012df1880e19078e831e4f1 @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8C8FF431FAF + for ; Sun, 5 Feb 2012 11:36:03 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id YtSFF-ei3O7c for ; + Sun, 5 Feb 2012 11:36:03 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C8362431FAE + for ; Sun, 5 Feb 2012 11:36:02 -0800 (PST) +Received: by bke11 with SMTP id 11so4919298bke.26 + for ; Sun, 05 Feb 2012 11:36:01 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=JuT/H47U2kaymkhe/URCd1R1QLqVnBwmeWsrOwxgzHw=; + b=sCvaoIYBehCbCbeYAJNSUunsPl0g6l+PPyf8BCZTYDmCiHDd1Zk1/3Sjif8RX8fq/n + DuYd3PDWirtZ3OIEF423PxLzakjUf4RcSUajUUr/bwWonWDaqKGnMPI4Qr7xP1meSxKJ + vAGnNmGWxdkoUFxTWCnDAgnVspBTb9InDbo4M= +Received: by 10.204.129.4 with SMTP id m4mr7063827bks.80.1328470561414; + Sun, 05 Feb 2012 11:36:01 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id d2sm37826928bky.11.2012.02.05.11.35.59 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 05 Feb 2012 11:36:00 -0800 (PST) +From: Dmitry Kurochkin +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() + arguments +In-Reply-To: <87y5sisrja.fsf@rocinante.cs.unb.ca> +References: <1327737753-18068-1-git-send-email-dmitry.kurochkin@gmail.com> + <87y5sisrja.fsf@rocinante.cs.unb.ca> +User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 05 Feb 2012 23:34:44 +0400 +Message-ID: <87aa4xhy5n.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Feb 2012 19:36:03 -0000 + +On Sat, 04 Feb 2012 07:37:45 -0500, David Bremner wrote: +> On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin wrote: +> > Argc and argv arguments are used in notmuch_tag_command() function. +> > So unused attribute is not appropriate for them. +> +> pushed, +> + +Are you sure? I do not see it in master. + +Regards, + Dmitry + +> d -- 2.26.2