From 1f83630369b7e57e8f84bb9c2fdef9a5ff76f954 Mon Sep 17 00:00:00 2001
From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Tue, 27 Mar 2012 23:01:19 +0300
Subject: [PATCH] Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring

---
 d1/2062a2a95e0d177c25d473c1253b2048253f75 | 91 +++++++++++++++++++++++
 1 file changed, 91 insertions(+)
 create mode 100644 d1/2062a2a95e0d177c25d473c1253b2048253f75

diff --git a/d1/2062a2a95e0d177c25d473c1253b2048253f75 b/d1/2062a2a95e0d177c25d473c1253b2048253f75
new file mode 100644
index 000000000..d53615d67
--- /dev/null
+++ b/d1/2062a2a95e0d177c25d473c1253b2048253f75
@@ -0,0 +1,91 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 6DC28431FAF
+	for <notmuch@notmuchmail.org>; Tue, 27 Mar 2012 13:01:25 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 2g47rz0KsJ0t for <notmuch@notmuchmail.org>;
+	Tue, 27 Mar 2012 13:01:23 -0700 (PDT)
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
+	by olra.theworths.org (Postfix) with ESMTP id 07DA3431FAE
+	for <notmuch@notmuchmail.org>; Tue, 27 Mar 2012 13:01:22 -0700 (PDT)
+Received: by guru.guru-group.fi (Postfix, from userid 501)
+	id D906B68055; Tue, 27 Mar 2012 23:01:19 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring
+In-Reply-To: <cover.1332795415.git.jani@nikula.org>
+References: <cover.1332795415.git.jani@nikula.org>User-Agent:
+ Notmuch/0.12+70~gce7ecf1	(http://notmuchmail.org) Emacs/23.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Tue, 27 Mar 2012 23:01:19 +0300
+Message-ID: <m28vilg6eo.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 27 Mar 2012 20:01:25 -0000
+
+On Tue, Mar 27 2012, Jani Nikula <jani@nikula.org> wrote:
+
+> v3 of id:"cover.1332702915.git.jani@nikula.org" with the following
+> mostly non-functional changes:
+>
+>  - add test for the current tagging behaviour in patch 1, and change the
+>    test in patch 2 when the behaviour is changed
+>  - handle the no tag changes case in _optimize_tag_query() in patch 2
+>  - add braces around the "tag_ops[tag_ops_count].remove = (argv[i][0] == '-');"
+>    assignment
+>  - document the tag_query() function a bit in patch 3
+>  - make tag_message() static in patch 4
+
+LGTM.
+
+>
+> BR,
+> Jani.
+
+Tomi
+
+>
+>
+> Jani Nikula (4):
+>   test: add test for both adding and removing a tag at the same time
+>   cli: refactor "notmuch tag" data structures for tagging operations
+>   cli: refactor "notmuch tag" query tagging into a separate function
+>   cli: refactor "notmuch restore" message tagging into a separate
+>     function
+>
+>  notmuch-restore.c |  148 ++++++++++++++++++++++++---------------------
+>  notmuch-tag.c     |  173 ++++++++++++++++++++++++++++-------------------------
+>  test/tagging      |    8 +++
+>  3 files changed, 178 insertions(+), 151 deletions(-)
+>
+> -- 
+> 1.7.5.4
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch
-- 
2.26.2