From 1d2da978e4baf43db49ea9bd04887e38ba6bda4c Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Wed, 5 Dec 2012 09:38:51 +1900 Subject: [PATCH] Re: [PATCH 1/1] Changing build tool for test/random-corpus to CXX instead of CC. --- 97/8f336a71dd982ea665450c371a6bf6341ad6ce | 105 ++++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 97/8f336a71dd982ea665450c371a6bf6341ad6ce diff --git a/97/8f336a71dd982ea665450c371a6bf6341ad6ce b/97/8f336a71dd982ea665450c371a6bf6341ad6ce new file mode 100644 index 000000000..f32bc9b7f --- /dev/null +++ b/97/8f336a71dd982ea665450c371a6bf6341ad6ce @@ -0,0 +1,105 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id CF34F431FB6 + for ; Tue, 4 Dec 2012 06:38:55 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Xi8Y7MdwH0Ok for ; + Tue, 4 Dec 2012 06:38:55 -0800 (PST) +Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU + [18.7.68.35]) + by olra.theworths.org (Postfix) with ESMTP id C7E6E431FAE + for ; Tue, 4 Dec 2012 06:38:54 -0800 (PST) +X-AuditID: 12074423-b7fcb6d000000927-6a-50be0afe69df +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP + id AF.6E.02343.EFA0EB05; Tue, 4 Dec 2012 09:38:54 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id qB4EcrSY000805; + Tue, 4 Dec 2012 09:38:54 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qB4EcpIB003226 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Tue, 4 Dec 2012 09:38:52 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1Tfte7-0000N4-JJ; Tue, 04 Dec 2012 09:38:51 -0500 +Date: Tue, 4 Dec 2012 09:38:51 -0500 +From: Austin Clements +To: Peter Feigl +Subject: Re: [PATCH 1/1] Changing build tool for test/random-corpus to CXX + instead of CC. +Message-ID: <20121204143851.GJ1020@mit.edu> +References: <1354628820-2262-1-git-send-email-craven@gmx.net> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1354628820-2262-1-git-send-email-craven@gmx.net> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IRYrdT0f3HtS/A4GezkMXehnZGi+s3ZzI7 + MHks3rSfzePZqlvMAUxRXDYpqTmZZalF+nYJXBnvzm5nLWjgqVi2+zhLA+M8ri5GTg4JAROJ + K7/nsUDYYhIX7q1n62Lk4hAS2Mcocf/JG0YIZz2jxL5pL5kgnAtMEpf7JkCVLWGUWNC3nRGk + n0VARWL96gYmEJtNQENi2/7lYHERAQWJZ+uawGxmAWmJb7+bwWqEBaIlTv6eDGbzCmhLTJxx + gx3EFhKwlVh2t48dIi4ocXLmExaIXi2JG/9AruAAm7P8HwdImFPATmLSqddsILYo0AlTTm5j + m8AoNAtJ9ywk3bMQuhcwMq9ilE3JrdLNTczMKU5N1i1OTszLSy3SNdPLzSzRS00p3cQIDmwX + 5R2Mfw4qHWIU4GBU4uGdcGtPgBBrYllxZe4hRkkOJiVR3hCWfQFCfEn5KZUZicUZ8UWlOanF + hxglOJiVRHgVPuwNEOJNSaysSi3Kh0lJc7AoifNeS7npLySQnliSmp2aWpBaBJOV4eBQkuC1 + B0awkGBRanpqRVpmTglCmomDE2Q4D9Dwv5xANbzFBYm5xZnpEPlTjIpS4rx8IM0CIImM0jy4 + XljiecUoDvSKMK8BSBUPMGnBdb8CGswENPiF0G6QwSWJCCmpBkYDxQStdmu/Q2EnL34y8Xhe + 5TOh6NQv08Lse6Y3fqunPb58/+sui0LHtgajLZy2kw5mOLFOXOpnyxL60Of+pksLvLcmHbEJ + TNCQyVh5de36pqnbPrw3lN954lD8Ad/SqvzKw7+duzp3BcX63v1lUXZU8cKCY/JHDv5Z/9ru + cUTIihARN8Fl4l1KLMUZiYZazEXFiQBtG3HBFwMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Dec 2012 14:38:56 -0000 + +LGTM. I think we build the main notmuch binary with g++ for the same +reason. + +Quoth Peter Feigl on Dec 04 at 2:47 pm: +> Without this change, GCC complains as follows: +> gcc test/random-corpus.o test/database-test.o notmuch-config.o command-line-arguments.o lib/libnotmuch.a util/libutil.a parse-time-string/libparse-time-string.a -o test/random-corpus -lgmime-2.6 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -Wl,-rpath,/usr/lib -ltalloc -lxapian +> /usr/bin/ld: lib/libnotmuch.a(database.o): undefined reference to symbol '_ZNSs4_Rep10_M_destroyERKSaIcE@@GLIBCXX_3.4' +> /usr/bin/ld: note: '_ZNSs4_Rep10_M_destroyERKSaIcE@@GLIBCXX_3.4' is defined in DSO /usr/lib/libstdc++.so.6 so try adding it to the linker command line +> /usr/lib/libstdc++.so.6: could not read symbols: Invalid operation +> collect2: error: ld returned 1 exit status +> make: *** [test/random-corpus] Error 1 +> --- +> test/Makefile.local | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/test/Makefile.local b/test/Makefile.local +> index 6a9f15e..2ec6595 100644 +> --- a/test/Makefile.local +> +++ b/test/Makefile.local +> @@ -22,7 +22,7 @@ random_corpus_deps = $(dir)/random-corpus.o $(dir)/database-test.o \ +> parse-time-string/libparse-time-string.a +> +> $(dir)/random-corpus: $(random_corpus_deps) +> - $(call quiet,CC) $(CFLAGS_FINAL) $^ -o $@ $(CONFIGURE_LDFLAGS) +> + $(call quiet,CXX) $(CFLAGS_FINAL) $^ -o $@ $(CONFIGURE_LDFLAGS) +> +> $(dir)/smtp-dummy: $(smtp_dummy_modules) +> $(call quiet,CC) $^ -o $@ -- 2.26.2