From 1be0baa610dd8b5a077f18eed8bcd35cf2714ccd Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 21 Jan 2013 00:55:28 +0200 Subject: [PATCH] Re: [PATCH 5/7] CLI: add --leak-report top level option --- 30/f96b2f1d9dab5fd57471c7f4894138b2775cd8 | 105 ++++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 30/f96b2f1d9dab5fd57471c7f4894138b2775cd8 diff --git a/30/f96b2f1d9dab5fd57471c7f4894138b2775cd8 b/30/f96b2f1d9dab5fd57471c7f4894138b2775cd8 new file mode 100644 index 000000000..5693690b6 --- /dev/null +++ b/30/f96b2f1d9dab5fd57471c7f4894138b2775cd8 @@ -0,0 +1,105 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id ADF78431FBD + for ; Sun, 20 Jan 2013 14:55:40 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id JBKbOlVeqzvr for ; + Sun, 20 Jan 2013 14:55:39 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 0C726431FB6 + for ; Sun, 20 Jan 2013 14:55:39 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 530BA100086; + Mon, 21 Jan 2013 00:55:28 +0200 (EET) +From: Tomi Ollila +To: Jameson Graef Rollins , david@tethera.net, + notmuch@notmuchmail.org +Subject: Re: [PATCH 5/7] CLI: add --leak-report top level option +In-Reply-To: <87d2wzwmd9.fsf@servo.finestructure.net> +References: <1358619958-21209-1-git-send-email-david@tethera.net> + <1358619958-21209-6-git-send-email-david@tethera.net> + <87d2wzwmd9.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.15+5~g6f527c2 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: David Bremner +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 20 Jan 2013 22:55:40 -0000 + +On Sun, Jan 20 2013, Jameson Graef Rollins wrote: + +> On Sat, Jan 19 2013, david@tethera.net wrote: +>> This roughly mimics the samba4 argument. The presence of the command +>> line argument overrides any value of NOTMUCH_TALLOC_REPORT in the +>> environment. +>> --- +>> man/man1/notmuch.1 | 8 ++++++++ +>> notmuch.c | 18 +++++++----------- +>> 2 files changed, 15 insertions(+), 11 deletions(-) +>> +>> diff --git a/man/man1/notmuch.1 b/man/man1/notmuch.1 +>> index 6bf9b2e..5c58c41 100644 +>> --- a/man/man1/notmuch.1 +>> +++ b/man/man1/notmuch.1 +>> @@ -70,6 +70,14 @@ Print a synopsis of available commands and exit. +>> Print the installed version of notmuch, and exit. +>> .RE +>> +>> +.RS 4 +>> +.TP 4 +>> +.BI \-\-leak-report= path +>> + +>> +Write a detailed report of all memory allocated via talloc to +>> +.I path +>> +.RE +> +> Do we really need a command line option for this? Why isn't the env var +> sufficient? This just seems to me like it clutters the interface, for +> an option that is purely for debugging and should rarely if ever be used +> by most users. + +Jameson does have a point. Now that we already have that environment +variable and it can be used in shipped notmuch 0.15 it is perhaps +simplest just to stick with that. + +My thoughts after brief first visit to the patche series has so far +being either make the command line usage 1:1 compatible with samba +or use option like --leak-report-output=..., --leak-report-file=... or +--leak-report-to=... (and attempt to deprecate the env var...) + +That said, I withdraw my previous suggestion of the command line option... + +The other changes in this patch series looks initially good -- and changes +that drop deprecated features should be get in as early after last release +as possible. + +> jamie. + + +Tomi -- 2.26.2