From 1af3ae8cf0bbbd3100c65ec144b2b0b4ac08ecf8 Mon Sep 17 00:00:00 2001 From: Adam Wolfe Gordon Date: Fri, 30 Mar 2012 11:18:54 +1800 Subject: [PATCH] Re: [BUG/PATCH v2] emacs: Fix the References header in reply --- 1d/7f94596c4834b9892f10289a939ce0dc6a9c2a | 99 +++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 1d/7f94596c4834b9892f10289a939ce0dc6a9c2a diff --git a/1d/7f94596c4834b9892f10289a939ce0dc6a9c2a b/1d/7f94596c4834b9892f10289a939ce0dc6a9c2a new file mode 100644 index 000000000..70bad123e --- /dev/null +++ b/1d/7f94596c4834b9892f10289a939ce0dc6a9c2a @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 34890431FAF + for ; Thu, 29 Mar 2012 10:18:58 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TUcRsC3tfUL6 for ; + Thu, 29 Mar 2012 10:18:57 -0700 (PDT) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6383F431FAE + for ; Thu, 29 Mar 2012 10:18:57 -0700 (PDT) +Received: by lahc1 with SMTP id c1so2816711lah.26 + for ; Thu, 29 Mar 2012 10:18:54 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:sender:x-originating-ip:in-reply-to:references:date + :x-google-sender-auth:message-id:subject:from:to:cc:content-type + :content-transfer-encoding:x-gm-message-state; + bh=QxQGazzz2JFObUoHAKTZWvs+C/h7HkWunLLYwQq838A=; + b=guKi5mpSOV/7BlMTYqqQ2S3zYA06JIlWHnPtoXtB8c2X+aEW5+6T1fhlxUHFqGAjpt + zRHKaNotQzm7S9fLM/0vCu80HnkEkyUzWe3qSNbo5eLabctlFgi11DIFa8QGlm9l8K0F + c7eqzCJEAbYw+paqC+iJWwnzNjAJp3UYABJ/AE/Ni2gq+pTz/kXcLPNVL3WFdqn+asuA + zY4KKubLj0p4qfL7pJFPjwChOn6XseCrONB7YiMNd+Rfgw+VRJlblb7Itb4w8kVeQOFc + OOsbQppbrL7zxtDqVmWzsT1v247adcLM11n8MW7zHaUaTlDxTtMz2Lt7Cn6DcaDavVy5 + H8EQ== +MIME-Version: 1.0 +Received: by 10.152.108.171 with SMTP id hl11mr28107458lab.29.1333041534374; + Thu, 29 Mar 2012 10:18:54 -0700 (PDT) +Sender: awg@xvx.ca +Received: by 10.112.97.14 with HTTP; Thu, 29 Mar 2012 10:18:54 -0700 (PDT) +X-Originating-IP: [128.221.197.57] +In-Reply-To: <87aa2zjpmg.fsf@servo.finestructure.net> +References: <1332991226-510-1-git-send-email-awg+notmuch@xvx.ca> + <1332996818-15700-1-git-send-email-awg+notmuch@xvx.ca> + <87aa2zjpmg.fsf@servo.finestructure.net> +Date: Thu, 29 Mar 2012 11:18:54 -0600 +X-Google-Sender-Auth: dOkJ0jlrET9fAC9RcnXzxNY94Vc +Message-ID: + +Subject: Re: [BUG/PATCH v2] emacs: Fix the References header in reply +From: Adam Wolfe Gordon +To: Jameson Graef Rollins +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQn7pVwxYy0lgGaYexoYyWIp8ZjTeFgbCl1+RCHgVfi/4FUllJpOhpD32ahwI5aMQ2Y1DGKp +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 29 Mar 2012 17:18:58 -0000 + +Hi Jamie, + +On Thu, Mar 29, 2012 at 11:14, Jameson Graef Rollins + wrote: +> I just tested this patch and it does seem to fix the issue. =A0However, a +> side effect seems to be that the References header is now appearing as +> the first header in the reply buffer, rather than the last, as it used +> to. =A0I suppose this is merely aesthetic, but I did prefer the ordering +> as it was before. =A0Is there a way to tweak the +> message-header-format-alist so that the References header appears last +> again? + +That's actually fixed by the new version [1]. As Austin mentioned in +his review, the order of message-header-format-alist determines the +order of the headers. + +[1] id:"1333038410-17927-3-git-send-email-awg+notmuch@xvx.ca" + +> Given the various things that are being affected by this, it would +> probably be good to add a test for this as well. + +Yeah, I think a test would be good. This isn't caught by the existing +emacs reply tests because the References and User-Agent headers are +hidden by default. Is there a function in emacs to tell message-mode +to show all the headers, so we can verify that they're correct? + +--=20 +Adam -- 2.26.2