From 1a512079983bcb8c82297d121079f025b651ab23 Mon Sep 17 00:00:00 2001 From: Adam Wolfe Gordon Date: Sun, 11 Mar 2012 11:29:04 +1700 Subject: [PATCH] Re: [PATCH v6 03/10] reply: Require that only one message is returned --- ae/8ba86f4512731f8783108b537451f186a4d620 | 90 +++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 ae/8ba86f4512731f8783108b537451f186a4d620 diff --git a/ae/8ba86f4512731f8783108b537451f186a4d620 b/ae/8ba86f4512731f8783108b537451f186a4d620 new file mode 100644 index 000000000..5b8fec451 --- /dev/null +++ b/ae/8ba86f4512731f8783108b537451f186a4d620 @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id EB32E431FBC + for ; Sat, 10 Mar 2012 10:29:06 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ULFh2tJunYOT for ; + Sat, 10 Mar 2012 10:29:06 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 36433431FAE + for ; Sat, 10 Mar 2012 10:29:06 -0800 (PST) +Received: by lahc1 with SMTP id c1so2772445lah.26 + for ; Sat, 10 Mar 2012 10:29:04 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:sender:x-originating-ip:in-reply-to:references:date + :x-google-sender-auth:message-id:subject:from:to:content-type + :x-gm-message-state; + bh=NWuezAJBGoVB4HemHs/ef68B6JpUvXp0JHbsZLzjRk4=; + b=fPpLWOgyfipjgiMgxkGsqCgMWbzmCudvhg1VCZKPH74A4rnKwPSLGdElZwErW9+QtD + wsEvio4Ao1fsGQyWbE1nmg9izmvwzIDWr/27kUsXzTbYlbUFjyUTsyCevVkjXJc1TNj1 + DbV9dt0hs+I1ok2SKIcSFBvreocUy6rrfdJ7AOifdAfJVR91UMH40RjxtN350x00X9b7 + sQ0ulPihdVR/BmYLoFhWF6afgtkapcDeeXUhjwzMtkdqhgkC8KX0/PRF4sHwHZDEeUyt + w8uhToyW1zP5T74XsEy8GUzNas6jYnJyKDDa182OkUMJDVjYx4wxDddGSZCjjvTIrZII + 3AlA== +MIME-Version: 1.0 +Received: by 10.152.113.136 with SMTP id iy8mr4724281lab.50.1331404144506; + Sat, 10 Mar 2012 10:29:04 -0800 (PST) +Sender: awg@xvx.ca +Received: by 10.112.109.234 with HTTP; Sat, 10 Mar 2012 10:29:04 -0800 (PST) +X-Originating-IP: [96.52.216.56] +In-Reply-To: <87fwdh8jmh.fsf@nikula.org> +References: <1329893199-21630-1-git-send-email-awg+notmuch@xvx.ca> + <1329893199-21630-4-git-send-email-awg+notmuch@xvx.ca> + <87fwdh8jmh.fsf@nikula.org> +Date: Sat, 10 Mar 2012 11:29:04 -0700 +X-Google-Sender-Auth: mhy8XL8VxT0nHfWcspO4j9Vn7xo +Message-ID: + +Subject: Re: [PATCH v6 03/10] reply: Require that only one message is returned +From: Adam Wolfe Gordon +To: Notmuch Mail +Content-Type: text/plain; charset=ISO-8859-1 +X-Gm-Message-State: + ALoCoQn+2xw7r8jiNFf2Q1l4BNGZtntKqtPK7RS478Cub0wmw69jfr7/Avoj9TYLhBkF9Pn6c7GQ +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 10 Mar 2012 18:29:07 -0000 + +On Fri, Mar 9, 2012 at 16:00, Jani Nikula wrote: +> On Tue, 21 Feb 2012 23:46:32 -0700, Adam Wolfe Gordon wrote: +>> As the semantics of replying to multiple messages have not yet been +>> defined well, make notmuch reply require that the search given returns +>> only a single message. +> +> Is there any real reason, apart from consistency between +> --format=default and --format=json, to disable the current multiple +> message reply? Also "notmuch show" has format specific features and +> limitations. +> +> I agree the semantics should be clarified, and eventually multiple +> message reply should be uniformly supported by all formats, including +> --format=json, but IMHO this patch should be dropped (and the TODO patch +> amended accordingly). + +It's just for consistency. I like the idea of dropping support for +multi-message replies everywhere now, then re-adding it with new +semantics later, but I don't feel very strongly about it. If people +who use the CLI would prefer to have the default format left as-is for +now that's OK with me. -- 2.26.2