From 182f1d02646023c231d43832418026deea802f05 Mon Sep 17 00:00:00 2001 From: Dmitry Kurochkin Date: Wed, 18 Apr 2012 18:41:52 +0400 Subject: [PATCH] Re: [PATCH v2 1/3] Add 'compose' command --- fd/9594417c42536bd18ebe806ca831abe5081b41 | 128 ++++++++++++++++++++++ 1 file changed, 128 insertions(+) create mode 100644 fd/9594417c42536bd18ebe806ca831abe5081b41 diff --git a/fd/9594417c42536bd18ebe806ca831abe5081b41 b/fd/9594417c42536bd18ebe806ca831abe5081b41 new file mode 100644 index 000000000..b3c9b1b43 --- /dev/null +++ b/fd/9594417c42536bd18ebe806ca831abe5081b41 @@ -0,0 +1,128 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id EE039431FBC + for ; Wed, 18 Apr 2012 07:44:02 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.185 +X-Spam-Level: +X-Spam-Status: No, score=-0.185 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_SORBS_WEB=0.614] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RQc-lCGFEDp0 for ; + Wed, 18 Apr 2012 07:43:59 -0700 (PDT) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id AF1AF431FAE + for ; Wed, 18 Apr 2012 07:43:58 -0700 (PDT) +Received: by lahc1 with SMTP id c1so5895921lah.26 + for ; Wed, 18 Apr 2012 07:43:57 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:content-transfer-encoding; + bh=7oXVd28XsTVvCoMwrPjkcHhtlozmx/ZmFEs4Tk8muqE=; + b=j31xqPgkU2IFfGJ/FpHW/VB6jQ2fTi2daa3gxPVL3+GumXv1QEN5o/2j24VvBaKRvv + MkilHs3+8VYmRbexufMva/Z3GOif2JMbS/fRTuUeJ49jMT4SHWQSTVfX8IgAcUTxt3iV + vE5XGNr2iAP45Vm+XZLKDAMJUkA3Vn9d90NRFl0ZcQMVrg4CE4QbOEjAuFNVm/wWG+rK + 6O41QMSmfsFPwfjJ8wKt9PAVAnnLKevw7nhhGyWBj2mOZA4RnkwskV0Fwzh2Mxzrb3Sd + M3h2+uNpXcLpJCgK1HFlEvH7AC2Jr2zxSMSiMRA6aDzN8yQp0HwNNrqp0tJ89ru+PT6B + m01A== +Received: by 10.152.147.100 with SMTP id tj4mr2348745lab.39.1334760236693; + Wed, 18 Apr 2012 07:43:56 -0700 (PDT) +Received: from localhost ([83.149.44.251]) + by mx.google.com with ESMTPS id mr15sm26502757lab.8.2012.04.18.07.43.50 + (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 18 Apr 2012 07:43:55 -0700 (PDT) +From: Dmitry Kurochkin +To: Felipe Contreras +Subject: Re: [PATCH v2 1/3] Add 'compose' command +In-Reply-To: + +References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com> + <1334752753-23970-2-git-send-email-felipe.contreras@gmail.com> + <873981chpj.fsf@nikula.org> + + <874nshm9yo.fsf@gmail.com> + +User-Agent: Notmuch/0.12+104~gf9ad237 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 18 Apr 2012 18:41:52 +0400 +Message-ID: <871unlm79r.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 18 Apr 2012 14:44:03 -0000 + +Felipe Contreras writes: + +> On Wed, Apr 18, 2012 at 4:43 PM, Dmitry Kurochkin +> wrote: +>> Hi Felipe. +>> +>> Felipe Contreras writes: +>> +>>> On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula wrote: +>>> +>>>> Running "notmuch compose" more than once within a second would result = +in +>>>> identical message ids for the messages, which is not a good idea. That= +'s +>>>> not likely in interactive use, but the notmuch cli is highly scriptabl= +e, +>>>> so someone is bound to hit this. +>>>> +>>>> Some paranoid might also be worried about "leaking" the time you run +>>>> "notmuch compose"... which may be different from the actual time you +>>>> send the message. +>>> +>>> It's still better than the current situation; nothing. In any case, +>>> people that have not needed this would not be affected; their UI would +>>> override the Message-ID. +>>> +>> +>> I disagree. =C2=A0If notmuch CLI generates a Message-ID, it must be a go= +od +>> one. =C2=A0Otherwise we make users falsely believe that they do have a p= +roper +>> Message-ID while in fact they do not. =C2=A0And that would bite them soo= +ner +>> or later. +> +> And then they'll report it, and we would fix it. +> +> Anyway, everything comes from a patch, so, do you have a patch, +> pseudo-code, or even a suggestion? +> + +A patch needs some positive reviews to be accepted. Replying to +comments with "make a better patch" may not be the best strategy for +getting your patches accepted. + +I do not have a patch. As for a suggestion, I would start with some +googling. If you did that, you would probably find the gmime function +kindly pointed out by Jani. + +Regards, + Dmitry + +> --=20 +> Felipe Contreras -- 2.26.2