From 17cfddd5d27c9730730e77fe28a09d0c4a6adce1 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 28 Nov 2012 10:40:28 +2000 Subject: [PATCH] Re: [PATCH] test: Quote $output in calls to test_expect_equal --- 48/b7cd2bfacfd5b05314bee4dfff44961a3ae013 | 66 +++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 48/b7cd2bfacfd5b05314bee4dfff44961a3ae013 diff --git a/48/b7cd2bfacfd5b05314bee4dfff44961a3ae013 b/48/b7cd2bfacfd5b05314bee4dfff44961a3ae013 new file mode 100644 index 000000000..9c2eed9c8 --- /dev/null +++ b/48/b7cd2bfacfd5b05314bee4dfff44961a3ae013 @@ -0,0 +1,66 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4A06E431FAF + for ; Tue, 27 Nov 2012 06:40:56 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9YAvdSnmcASJ for ; + Tue, 27 Nov 2012 06:40:55 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id CD81E431FAE + for ; Tue, 27 Nov 2012 06:40:55 -0800 (PST) +Received: from convex-new.cs.unb.ca ([131.202.245.35]) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) + id 1TdMLG-0001bT-K8; Tue, 27 Nov 2012 10:40:54 -0400 +Received: from bremner by convex-new.cs.unb.ca with local (Exim 4.80) + (envelope-from ) + id 1TdMKq-0001Lo-96; Tue, 27 Nov 2012 10:40:28 -0400 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: Quote $output in calls to test_expect_equal +In-Reply-To: <1353992297-14473-1-git-send-email-amdragon@mit.edu> +References: <1353992297-14473-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.14+76~g84a0c52 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Tue, 27 Nov 2012 10:40:28 -0400 +Message-ID: <87lidncdnn.fsf@convex-new.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 27 Nov 2012 14:40:56 -0000 + +Austin Clements writes: + +> Previously, many tests in emacs-subject-to-filename didn't quote the +> $output argument to test_expect_equal. As a result, if $output was +> empty, test_expect_equal would be passed only one argument and would +> abort the entire test script. By quoting the argument, we ensure +> test_expect_equal will always receive two arguments. + +Pushed. + +d -- 2.26.2