From 171355497c0d7df5195427366fcb14962d2e85e7 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Tue, 3 Apr 2012 01:20:51 +1700 Subject: [PATCH] [PATCH 4/6] emacs: remove redundant notmuch-search-tag-thread function --- fb/85284e5f5d21d5c3b6b3b9b68832f43303357f | 96 +++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 fb/85284e5f5d21d5c3b6b3b9b68832f43303357f diff --git a/fb/85284e5f5d21d5c3b6b3b9b68832f43303357f b/fb/85284e5f5d21d5c3b6b3b9b68832f43303357f new file mode 100644 index 000000000..5029fa459 --- /dev/null +++ b/fb/85284e5f5d21d5c3b6b3b9b68832f43303357f @@ -0,0 +1,96 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 92AAF41ED8C + for ; Mon, 2 Apr 2012 01:21:10 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id He499kO3vZvV for ; + Mon, 2 Apr 2012 01:21:08 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id F09F441ED8E + for ; Mon, 2 Apr 2012 01:21:01 -0700 (PDT) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id C47262E509DC + for ; Mon, 2 Apr 2012 01:21:01 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.193.65]) + (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id 142DA2E50C6E + for ; Mon, 2 Apr 2012 01:20:57 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 9784719E6; Mon, 2 Apr 2012 01:20:56 -0700 (PDT) +From: Jameson Graef Rollins +To: Notmuch Mail +Subject: [PATCH 4/6] emacs: remove redundant notmuch-search-tag-thread + function +Date: Mon, 2 Apr 2012 01:20:51 -0700 +Message-Id: <1333354853-25729-5-git-send-email-jrollins@finestructure.net> +X-Mailer: git-send-email 1.7.9.1 +In-Reply-To: <1333354853-25729-4-git-send-email-jrollins@finestructure.net> +References: <1333354853-25729-1-git-send-email-jrollins@finestructure.net> + <1333354853-25729-2-git-send-email-jrollins@finestructure.net> + <1333354853-25729-3-git-send-email-jrollins@finestructure.net> + <1333354853-25729-4-git-send-email-jrollins@finestructure.net> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 02 Apr 2012 08:21:11 -0000 + +Now that the notmuch-search-tag functions provides the exact same +functionality, this function is now entirely redundant. Keeping it +around would just be bloat and confusion. notmuch-search-tag should +now be the canonical function for search-mode tag changes. + +The archive-thread function (which was the only function to use +tag-thread) is updating accordingly. +--- + emacs/notmuch.el | 8 +------- + 1 files changed, 1 insertions(+), 7 deletions(-) + +diff --git a/emacs/notmuch.el b/emacs/notmuch.el +index 3b78584..e1bff42 100644 +--- a/emacs/notmuch.el ++++ b/emacs/notmuch.el +@@ -624,12 +624,6 @@ the messages that were tagged" + (forward-line 1)) + output))) + +-(defun notmuch-search-tag-thread (&rest tag-changes) +- "Change tags for the currently selected thread. +- +-See `notmuch-search-tag-region' for details." +- (apply 'notmuch-search-tag-region (point) (point) tag-changes)) +- + (defun notmuch-search-tag-region (beg end &rest tag-changes) + "Change tags for threads in the given region. + +@@ -678,7 +672,7 @@ tab completion)." + + This function advances the next thread when finished." + (interactive) +- (notmuch-search-tag-thread "-inbox") ++ (notmuch-search-tag "-inbox") + (notmuch-search-next-thread)) + + (defvar notmuch-search-process-filter-data nil +-- +1.7.9.1 + -- 2.26.2