From 166bcad6596e039635c129041512dd4a4abc74ed Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 11 Apr 2012 21:57:45 +0300 Subject: [PATCH] Re: [PATCH 2/4] dirent->d_type not available on Soalris --- 10/963ac328ad555d962ca6a008e23241232d1d45 | 75 +++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 10/963ac328ad555d962ca6a008e23241232d1d45 diff --git a/10/963ac328ad555d962ca6a008e23241232d1d45 b/10/963ac328ad555d962ca6a008e23241232d1d45 new file mode 100644 index 000000000..c285dc934 --- /dev/null +++ b/10/963ac328ad555d962ca6a008e23241232d1d45 @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id ED869431FAF + for ; Wed, 11 Apr 2012 11:57:49 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 0aNI4uxERNot for ; + Wed, 11 Apr 2012 11:57:49 -0700 (PDT) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id 5AA66431FAE + for ; Wed, 11 Apr 2012 11:57:49 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id D8D1168055; Wed, 11 Apr 2012 21:57:45 +0300 (EEST) +From: Tomi Ollila +To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org +Subject: Re: [PATCH 2/4] dirent->d_type not available on Soalris +In-Reply-To: <1333989127-21523-1-git-send-email-Vladimir.Marek@oracle.com> +References: + + <1333989127-21523-1-git-send-email-Vladimir.Marek@oracle.com>User-Agent: + Notmuch/0.12+77~gee11800 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: Vladimir Marek +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 11 Apr 2012 18:57:50 -0000 + +On Mon, Apr 09 2012, Vladimir.Marek@oracle.com wrote: + +> From: Vladimir Marek +> +> The inspiration was taken from similar issue in mutt: +> http://does-not-exist.org/mail-archives/mutt-dev/msg11290.html +> +> Signed-off-by: Vladimir Marek +> --- + +Code looks pretty good, but 2 issues + +1) Commit message should contain more verbose information what and + why something was done. + +2) Does these #ifdefs break code indenters such as uncrustify(1), + indent(1) and emacs(1) indent functionality. + (That used to happen but maybe these indenters are smarted today. + +Tomi + +> notmuch-new.c | 28 ++++++++++++++++++++++++++++ +> 1 files changed, 28 insertions(+), 0 deletions(-) -- 2.26.2