From 15e4a451bc717c6de020bffbd33ddb68897a0eb6 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Tue, 6 Nov 2012 09:07:22 +0200 Subject: [PATCH] Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to know --- 51/e2c6b918fd2d2e6f7ce44d26782489c460b93b | 92 +++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 51/e2c6b918fd2d2e6f7ce44d26782489c460b93b diff --git a/51/e2c6b918fd2d2e6f7ce44d26782489c460b93b b/51/e2c6b918fd2d2e6f7ce44d26782489c460b93b new file mode 100644 index 000000000..6ee11f0d0 --- /dev/null +++ b/51/e2c6b918fd2d2e6f7ce44d26782489c460b93b @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 745BE431FB6 + for ; Mon, 5 Nov 2012 23:07:24 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TgI9P9IHu+lo for ; + Mon, 5 Nov 2012 23:07:23 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 9E2C9431FAE + for ; Mon, 5 Nov 2012 23:07:23 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id DA406100094; + Tue, 6 Nov 2012 09:07:22 +0200 (EET) +From: Tomi Ollila +To: Ethan Glasser-Camp , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to + know +In-Reply-To: <87390nid3c.fsf@betacantrips.com> +References: <1351865226-916-1-git-send-email-tomi.ollila@iki.fi> + <87390nid3c.fsf@betacantrips.com> +User-Agent: Notmuch/0.14+81~gb8371cd (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 06 Nov 2012 07:07:24 -0000 + +On Tue, Nov 06 2012, Ethan Glasser-Camp wrote: + +> Tomi Ollila writes: +> +>> Added FILE, notmuch_show_params_t and sprinter_t to be +>> types when uncrustifying sources. This affect spacing +>> when uncrustify is deciding for type declaration instead +>> of binary multiplication operation. +> +> This looks good to me. If you had plenty of time and no more patches to +> review, I'd prefer the slightly cleaner English: +> +> This affects how uncrustify puts spacing around pointers to these types, +> since it can parse them as type declarations instead of binary +> multiplication operations. +> +> ... but even suggesting this indicates I've moved past the bike shed and +> into somebody else's kitchen. + +I always appreciate anybody putting effort to translate my scrawls into +more cleaner expressions ;D + +If the change were more important I'd take time to improve the commit +message. + +Like one of our famous contributors have said: + +"I also don't think we have to be totally obsessive about our commit history." + +and + +"I doubt it would make much difference in the grand scheme of things." + +:D + +> Ethan + +Thanks, + +Tomi -- 2.26.2