From 11ebefb0fa000520e4fa0f68aad9067faa4791b9 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 24 Mar 2012 12:06:06 +0200 Subject: [PATCH] Re: [PATCH 0/3] Rewrite default reply format --- fe/12ff2a8b13244908ed370a65626c89b33ff21f | 78 +++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 fe/12ff2a8b13244908ed370a65626c89b33ff21f diff --git a/fe/12ff2a8b13244908ed370a65626c89b33ff21f b/fe/12ff2a8b13244908ed370a65626c89b33ff21f new file mode 100644 index 000000000..502383a6d --- /dev/null +++ b/fe/12ff2a8b13244908ed370a65626c89b33ff21f @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0AFC2431FAF + for ; Sat, 24 Mar 2012 03:06:16 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id cV86dYXVGGYg for ; + Sat, 24 Mar 2012 03:06:15 -0700 (PDT) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id 1A786431FAE + for ; Sat, 24 Mar 2012 03:06:15 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 55EB668055; Sat, 24 Mar 2012 12:06:06 +0200 (EET) +From: Tomi Ollila +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/3] Rewrite default reply format +In-Reply-To: <1332473647-9133-1-git-send-email-amdragon@mit.edu> +References: <1332473647-9133-1-git-send-email-amdragon@mit.edu>User-Agent: + Notmuch/0.12+71~gdacf76b (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 24 Mar 2012 10:06:16 -0000 + +Austin Clements writes: + +> The default reply format is the last bastion of the old message +> formatter style. This series converts it to the new self-recursive +> style. After this, there will be one last series to rip out the +> compatibility code and do final cleanup. + +Works fine, patches look good... just 2 "spacing" questions: + +in id:"1332473647-9133-2-git-send-email-amdragon@mit.edu" + ++ typedef enum { ++ NOTMUCH_SHOW_TEXT_PART_REPLY = 1<<0, ++ } notmuch_show_text_part_flags; + +Should this be like: NOTMUCH_SHOW_TEXT_PART_REPLY = (1 << 0), + +and this + ++ * If flags&NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each ++ * output line. ++ * + +like: + ++ * If flags & NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each + + +Tomi -- 2.26.2