From 117b5d126defb7dc47a1699e07e9d88593596928 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 19 Mar 2012 08:46:59 +2100 Subject: [PATCH] Re: [PATCH] Fix error reporting in notmuch_database_find_message_by_filename --- 27/67715b52c376d68c655d8bef55facd39654a22 | 67 +++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 27/67715b52c376d68c655d8bef55facd39654a22 diff --git a/27/67715b52c376d68c655d8bef55facd39654a22 b/27/67715b52c376d68c655d8bef55facd39654a22 new file mode 100644 index 000000000..3daaf8e4a --- /dev/null +++ b/27/67715b52c376d68c655d8bef55facd39654a22 @@ -0,0 +1,67 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E35E2431FAF + for ; Sun, 18 Mar 2012 04:47:09 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id zd+pmlwZW6qo for ; + Sun, 18 Mar 2012 04:47:09 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 37B77431FAE + for ; Sun, 18 Mar 2012 04:47:09 -0700 (PDT) +Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net + ([142.166.230.117] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) + (Exim 4.72) (envelope-from ) + id 1S9EZl-0006g0-7r; Sun, 18 Mar 2012 08:47:05 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.77) + (envelope-from ) + id 1S9EZf-0002oL-Vg; Sun, 18 Mar 2012 08:47:00 -0300 +From: David Bremner +To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org +Subject: Re: [PATCH] Fix error reporting in + notmuch_database_find_message_by_filename +In-Reply-To: + <1332002487-32411-2-git-send-email-4winter@informatik.uni-hamburg.de> +References: + <1332002487-32411-1-git-send-email-4winter@informatik.uni-hamburg.de> + <1332002487-32411-2-git-send-email-4winter@informatik.uni-hamburg.de> +User-Agent: Notmuch/0.12~rc2 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 18 Mar 2012 08:46:59 -0300 +Message-ID: <8762e2m8r0.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 18 Mar 2012 11:47:10 -0000 + +On Sat, 17 Mar 2012 17:41:27 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote: +> Formerly it was possible for *message_ret to be left +> uninitialized. The documentation however clearly states that "[o]n any +> failure or when the message is not found, this function initializes +> '*message' to NULL". +> + +Pushed to 0.12 -- 2.26.2