From 115c812186912a2c7166aa4e2ee83b39a98b0069 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Tue, 3 Apr 2012 14:20:11 +1700 Subject: [PATCH] Re: [PATCH 6/8] cli: add support for batch tagging operations to "notmuch tag" --- 71/2f5a4cc811d2c27f8e27073553ab9db5474b69 | 100 ++++++++++++++++++++++ 1 file changed, 100 insertions(+) create mode 100644 71/2f5a4cc811d2c27f8e27073553ab9db5474b69 diff --git a/71/2f5a4cc811d2c27f8e27073553ab9db5474b69 b/71/2f5a4cc811d2c27f8e27073553ab9db5474b69 new file mode 100644 index 000000000..ff6f09b76 --- /dev/null +++ b/71/2f5a4cc811d2c27f8e27073553ab9db5474b69 @@ -0,0 +1,100 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C24C1431FB6 + for ; Mon, 2 Apr 2012 14:20:23 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id lXcphwEoibOk for ; + Mon, 2 Apr 2012 14:20:21 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 40C4D431FAE + for ; Mon, 2 Apr 2012 14:20:21 -0700 (PDT) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id 82DF232802D; + Mon, 2 Apr 2012 14:20:19 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (gwave-213.ligo.caltech.edu + [131.215.114.213]) (Authenticated sender: jrollins) by fire-doxen-submit + (Postfix) with ESMTP id 7BA782E50E2D; Mon, 2 Apr 2012 14:20:14 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 3F4BF7F4; Mon, 2 Apr 2012 14:20:14 -0700 (PDT) +From: Jameson Graef Rollins +To: Jani Nikula +Subject: Re: [PATCH 6/8] cli: add support for batch tagging operations to + "notmuch tag" +In-Reply-To: + +References: + + <87ty123tpc.fsf@servo.finestructure.net> + <87aa2tc22z.fsf@zancas.localnet> + <87iphh50hz.fsf@servo.finestructure.net> + +User-Agent: Notmuch/0.12+87~g3c4c85f (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 02 Apr 2012 14:20:11 -0700 +Message-ID: <87fwcl4yr8.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 02 Apr 2012 21:20:23 -0000 + +--=-=-= + +On Mon, Apr 02 2012, Jani Nikula wrote: +> Batch tagging brings performance and atomicity by opening and closing the +> db only once. The hex encoding handles insane message ids and tags. +> Otherwise there should be no difference. + +I can maybe see performance in terms of opening and closing the db only +once, but atomicity? Not sure I see how that is improved. + +And shouldn't we be able to improve the handling of command line +arguments so that we get the same encoding handling on the command line +as we would from stdin? + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJPehgLAAoJEO00zqvie6q8b28P/RdtI1iyvRos9edie7xI9QH7 +y34ycGbiRI056CcYR5QKVLaTECTZRBQcVFveZSAX6Qi3WRbs/gde9owLU52bh/gg +993RKA34EVXIzoZcdhOFmrNkK3py44r+Sq+wsE4VYLjtZmzcRLncl56c2tprBhm8 +kh4K8WisLz9FvoibJWn1zLkA8W/biEukF8iS+KEOeFsWee1wg6uzuz4cBC1WXdNG +fOjsQCDK2PsJhOaQu56QvKFeJCtHJFPCu+XumC6ieK8PBSbsGPHftcJLJhxtrspg +MQG01I/idabtWK3R3eAgg7HnTLV7gzPUGDCn3hTnrmDLOJ3lMuN5eTC+oSePoEGA +oEjHK5vijtFd7GNfcCO6TjAJFfO1k+mSXuYTczvqLNeZlhQ1Ei6d2kbW5ANX/1Ua +aPkx7z2XI+Jr1Bg9u9Mbnsj25O99JM/xPNfbQZXxXSXzjF6Xd3+VCk0RwTSc1cnu +beZwnBWba/wugsI9abF/y3UfF8kzbFFUlKVN7/Gy1bC7fdq/pnxSzFZREIfT3O+f +8uPtvIvcID5V6gKizX0atrw44ZPme7PpOxoLSX8/Lv/QMm+Wuc5iQeVoyt2wnM30 +VqBhVr3JbmTHyAniXowhMnh9l6K+Lz7LE/CaqyMjNUIV8jqf2bHpIL2HQs5zc+Li +bq70iXjIAW3DkxzCARfq +=3/7b +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2