From 103247da60c04c4a1ea2453af50d2bed14008ebb Mon Sep 17 00:00:00 2001
From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Wed, 14 Nov 2012 10:32:19 +0200
Subject: [PATCH] Re: [PATCH v2 0/3] Better id: link buttonization

---
 9f/f4ed36654e8f3d490300e4c85ea65fb841d035 | 80 +++++++++++++++++++++++
 1 file changed, 80 insertions(+)
 create mode 100644 9f/f4ed36654e8f3d490300e4c85ea65fb841d035

diff --git a/9f/f4ed36654e8f3d490300e4c85ea65fb841d035 b/9f/f4ed36654e8f3d490300e4c85ea65fb841d035
new file mode 100644
index 000000000..57ba726f6
--- /dev/null
+++ b/9f/f4ed36654e8f3d490300e4c85ea65fb841d035
@@ -0,0 +1,80 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1B5ED431FBC
+	for <notmuch@notmuchmail.org>; Wed, 14 Nov 2012 00:32:23 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id EOiP1rh7s3TT for <notmuch@notmuchmail.org>;
+	Wed, 14 Nov 2012 00:32:22 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 2BA89431FAF
+	for <notmuch@notmuchmail.org>; Wed, 14 Nov 2012 00:32:22 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 563AB1000E2;
+	Wed, 14 Nov 2012 10:32:20 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>,
+	Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v2 0/3] Better id: link buttonization
+In-Reply-To: <87k3to6h9p.fsf@betacantrips.com>
+References: <1352609175-12790-1-git-send-email-amdragon@mit.edu>
+	<87k3to6h9p.fsf@betacantrips.com>
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Wed, 14 Nov 2012 10:32:19 +0200
+Message-ID: <m2obj0ega4.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: sascha-ml-reply-to-2012-4@silbe.org
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 14 Nov 2012 08:32:23 -0000
+
+On Wed, Nov 14 2012, Ethan Glasser-Camp wrote:
+
+> Austin Clements <amdragon@MIT.EDU> writes:
+>
+>> This is v2 of id:"1351650561-7331-1-git-send-email-amdragon@mit.edu".
+>> This makes Jani's suggested additions to the regexp and adds support
+>> for RFC 2392 mid: links, as suggested by Sascha.
+>
+> This series looks fine to me.
+
+LGTM too. 
+
+although this is different than others in test/emacs:
+
+ +test_expect_equal_file EXPECTED OUTPUT
+
+(grep test_expect_equal_file test/emacs)
+
+The diff output in case of failure makes more sense when the args
+are in this order -- but probably that should be changed
+bu changing the arg handling order in test_expect_equal_file
+(to be consistent with test_expect_equal) and then change the order
+in the "remaining" uses of test_expect_equal_file EXPECTED OUTPUT.
+
+> Ethan
+
+Tomi
-- 
2.26.2