From 0ec81b0aaac965252d41790b8bbcce7fe80a61f3 Mon Sep 17 00:00:00 2001 From: Pieter Praet Date: Fri, 3 Feb 2012 11:20:58 +0100 Subject: [PATCH] Re: [PATCH] test: replace occurrences of $PWD with vars that are more stable --- 73/1e362f6a8234a989b7314cd0985bb1010f7018 | 89 +++++++++++++++++++++++ 1 file changed, 89 insertions(+) create mode 100644 73/1e362f6a8234a989b7314cd0985bb1010f7018 diff --git a/73/1e362f6a8234a989b7314cd0985bb1010f7018 b/73/1e362f6a8234a989b7314cd0985bb1010f7018 new file mode 100644 index 000000000..2ee3330e3 --- /dev/null +++ b/73/1e362f6a8234a989b7314cd0985bb1010f7018 @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8E59E431FAF + for ; Fri, 3 Feb 2012 02:23:21 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 0zbzuxKMgOaH for ; + Fri, 3 Feb 2012 02:23:21 -0800 (PST) +Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com + [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 07579431FAE + for ; Fri, 3 Feb 2012 02:23:03 -0800 (PST) +Received: by wibhi8 with SMTP id hi8so2695678wib.26 + for ; Fri, 03 Feb 2012 02:23:02 -0800 (PST) +Received: by 10.180.97.196 with SMTP id ec4mr9485233wib.11.1328264582377; + Fri, 03 Feb 2012 02:23:02 -0800 (PST) +Received: from localhost ([109.131.13.166]) + by mx.google.com with ESMTPS id ho4sm5531373wib.3.2012.02.03.02.23.01 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 03 Feb 2012 02:23:01 -0800 (PST) +From: Pieter Praet +To: Dmitry Kurochkin +Subject: Re: [PATCH] test: replace occurrences of $PWD with vars that are more + stable +In-Reply-To: <878vkmm9qk.fsf@gmail.com> +References: <87ipjqb8c1.fsf@praet.org> + <1328128641-31155-1-git-send-email-pieter@praet.org> + <878vkmm9qk.fsf@gmail.com> +User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +Date: Fri, 03 Feb 2012 11:20:58 +0100 +Message-ID: <87ty382p6d.fsf@praet.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 03 Feb 2012 10:23:21 -0000 + +On Thu, 02 Feb 2012 03:09:39 +0400, Dmitry Kurochkin wrote: +> [...] +> I would prefer to put the whole second argument inside the quotes, not +> just the variable. +> [...] +> + +I felt the same way initially, but then decided to leave the extra +quotes in place because the resulting fontification helps differentiate +between the vars and actual strings. + +I assume that was the reason for the extra quotes' presence in the first +place? I might be wrong though... + +So with that in mind, do I submit a new patch without the quotes, or leave +it as it is? + +> Regards, +> Dmitry +> +> > mkdir -p "$(dirname "$external_msg_filename")" +> > mv "$gen_msg_filename" "$external_msg_filename" +> > ln -s "$external_msg_filename" "$gen_msg_filename" +> > -- +> > 1.7.8.1 + + +Peace + +-- +Pieter -- 2.26.2