From 0eb5a3e4fbf69f9f4d1e8731acb2fa8e53dae4c0 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Tue, 4 Dec 2012 00:35:46 +0200 Subject: [PATCH] Re: [PATCH 2/2] cli: convert "notmuch new" to the argument parser --- 51/328048ad70860bb4b49a5236166caa453ad80c | 88 +++++++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 51/328048ad70860bb4b49a5236166caa453ad80c diff --git a/51/328048ad70860bb4b49a5236166caa453ad80c b/51/328048ad70860bb4b49a5236166caa453ad80c new file mode 100644 index 000000000..6e4a671f3 --- /dev/null +++ b/51/328048ad70860bb4b49a5236166caa453ad80c @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BC221431FBC + for ; Mon, 3 Dec 2012 14:35:51 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id bjZPdu+SDtG3 for ; + Mon, 3 Dec 2012 14:35:51 -0800 (PST) +Received: from mail-la0-f53.google.com (mail-la0-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D50F3431FAE + for ; Mon, 3 Dec 2012 14:35:50 -0800 (PST) +Received: by mail-la0-f53.google.com with SMTP id w12so2826649lag.26 + for ; Mon, 03 Dec 2012 14:35:49 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=AzDf/g76UAefjoqHgMwh1Dxd469ejr9vgyVfWu2SvTQ=; + b=geOghk6K48BHHumGg0CbjvkMMe4Mci4xwKxuP4h4Ik6zKXVKHQtjQdh3si0ZVewHCD + XECeoQekyHL4ipgKYs8eItgeA9DRn1y1EugJeUECvTQBM42yfRjtsX/VUvqxYTvydPSq + 5NzvAoMXA5i+khV2ZKCCPQzwPj1Dub1Yy5ugm30frVN4xYaJhCCviW4dA2sPgkcVMRJ3 + 0ygPD6Rq19z8BBdtEMlQM8R6wDwyn8jb6auzwj2lpo0cqZj/nNsf3rS/eedvzzIQp/zd + 51SL/KqlsO5ajcXxHm6sjlV1WOF2g8DoZ4HJ5LcrnUZFzw9LLeyn/VNrmlst5OJCbA3E + VoBQ== +Received: by 10.112.47.168 with SMTP id e8mr4998525lbn.46.1354574149323; + Mon, 03 Dec 2012 14:35:49 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id ly18sm5886807lab.15.2012.12.03.14.35.47 + (version=SSLv3 cipher=OTHER); Mon, 03 Dec 2012 14:35:48 -0800 (PST) +From: Jani Nikula +To: Austin Clements +Subject: Re: [PATCH 2/2] cli: convert "notmuch new" to the argument parser +In-Reply-To: <20121203222844.GH1020@mit.edu> +References: + + + <20121203222844.GH1020@mit.edu> +User-Agent: Notmuch/0.14+137~g9203c35 (http://notmuchmail.org) Emacs/23.4.1 + (i686-pc-linux-gnu) +Date: Tue, 04 Dec 2012 00:35:46 +0200 +Message-ID: <87y5he9325.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQlZeuMIMi8+D+vPtzXryZPG1KT8HI43TKkaOGd4gt2TCYZ1NX4TmOm7G/mF0jl3jcrm9XJa +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 03 Dec 2012 22:35:51 -0000 + +On Tue, 04 Dec 2012, Austin Clements wrote: +>> - argc--; argv++; /* skip subcommand argument */ +>> + notmuch_opt_desc_t options[] = { +>> + { NOTMUCH_OPT_BOOLEAN, &add_files_state.verbose, "verbose", 'v', 0 }, +>> + { NOTMUCH_OPT_BOOLEAN, &add_files_state.debug, "debug", 'd', 0 }, +>> + { NOTMUCH_OPT_BOOLEAN, &no_hooks, "no-hooks", 'n', 0 }, +> +> Not that the single character arguments matter right now, but '-n' is +> often used for "dry-run", which could actually apply to notmuch new. + +Agreed, although I believe we'd have to review all of the single +character arguments before actually enabling any of them. At least my +choice of them has been rather whimsical. I'll leave this up to David to +decide. + +BR, +Jani. -- 2.26.2