From 0d9b567c7dbbdb4a285aa35fd8c217ad36cfefc7 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sun, 13 Jan 2013 16:41:28 +0200 Subject: [PATCH] Re: [PATCH 1/1] cli: propagate batch tagging warnings to exit value --- f8/a3521c966d084591f4e511ca2be27660065497 | 117 ++++++++++++++++++++++ 1 file changed, 117 insertions(+) create mode 100644 f8/a3521c966d084591f4e511ca2be27660065497 diff --git a/f8/a3521c966d084591f4e511ca2be27660065497 b/f8/a3521c966d084591f4e511ca2be27660065497 new file mode 100644 index 000000000..4bc84156d --- /dev/null +++ b/f8/a3521c966d084591f4e511ca2be27660065497 @@ -0,0 +1,117 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id EEF71431FB6 + for ; Sun, 13 Jan 2013 06:41:30 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.699 +X-Spam-Level: +X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 + tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UiS8Z6APGodf for ; + Sun, 13 Jan 2013 06:41:30 -0800 (PST) +Received: from mail-vb0-f49.google.com (mail-vb0-f49.google.com + [209.85.212.49]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 598F9431FAF + for ; Sun, 13 Jan 2013 06:41:30 -0800 (PST) +Received: by mail-vb0-f49.google.com with SMTP id s24so2305779vbi.8 + for ; Sun, 13 Jan 2013 06:41:28 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:in-reply-to:references:date:message-id:subject:from:to + :cc:content-type:x-gm-message-state; + bh=8ntwEpF+ROVGgBq/UFcsTVfA6kMnU9QR/qGZ+1TifLs=; + b=N/axl9Cpwk7rWgnYvL868mVosLsHJygeTxUpkGqdNCGbp8OGwDJOYEQv9LxWFib18L + PdnuXQ+KwxsN0vuafBCFeXzdnInltg3l2L7z8/GGJQSIgeOviiBrsuWHaPIozJG08Tzg + XH8HjoT7O3pnrZ4WcFIBaXEkerZ6Rzr2AEyRWujKoUFxeSgHoTORAUa7ZWya5WcHWe9o + N4pd86r3/LX+xM7UQB8BVRIQ9m+mCtojYdXMNclVa1qQA54nYvNq2hTpsF/1tMuv4smw + XJwgcUNXcsQKFjNPZRI6eQHlrUCg8Tmo+4hOa7vas+xy3k6NOEp1RsDjrourk6/iIrW6 + eqIQ== +MIME-Version: 1.0 +Received: by 10.52.16.17 with SMTP id b17mr86696289vdd.86.1358088088610; Sun, + 13 Jan 2013 06:41:28 -0800 (PST) +Received: by 10.58.248.132 with HTTP; Sun, 13 Jan 2013 06:41:28 -0800 (PST) +Received: by 10.58.248.132 with HTTP; Sun, 13 Jan 2013 06:41:28 -0800 (PST) +In-Reply-To: <87fw25cfnw.fsf@zancas.localnet> +References: <1357976414-7468-1-git-send-email-tomi.ollila@iki.fi> + <87fw25cfnw.fsf@zancas.localnet> +Date: Sun, 13 Jan 2013 16:41:28 +0200 +Message-ID: + +Subject: Re: [PATCH 1/1] cli: propagate batch tagging warnings to exit value +From: Jani Nikula +To: David Bremner +Content-Type: multipart/alternative; boundary=bcaec50408e818663b04d32c8672 +X-Gm-Message-State: + ALoCoQlkQN3EjMqaaZmAaeEnAlB6TpgBFljsz+byI7lX0o6zglqS0zwrSS+8uv0mm8l9R8AyOoD+ +Cc: Tomi Ollila , Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 13 Jan 2013 14:41:31 -0000 + +--bcaec50408e818663b04d32c8672 +Content-Type: text/plain; charset=UTF-8 + +On Jan 13, 2013 4:37 PM, "David Bremner" wrote: +> +> Tomi Ollila writes: +> +> > In case last input for batch tagging was either invalid or skippable +> > line, notmuch command exited with non-zero value. +> > After this change if there is at least one invalid line, notmuch +> > command will exit with non-zero value. Additionally, skipped lines +> > (last or other) doesn't cause non-zero value to be returned. +> +> This looks OK. In a perfect world we'd have a test for return values. + +And distinct codes for warnings and errors... but can't have everything at +once... + +J. + +> d +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch + +--bcaec50408e818663b04d32c8672 +Content-Type: text/html; charset=UTF-8 + +


+On Jan 13, 2013 4:37 PM, "David Bremner" <david@tethera.net> wrote:
+>
+> Tomi Ollila <tomi.ollila@iki.fi> writes:
+>
+> > In case last input for batch tagging was either invalid or skippable
+> > line, notmuch command exited with non-zero value.
+> > After this change if there is at least one invalid line, notmuch
+> > command will exit with non-zero value. Additionally, skipped lines
+> > (last or other) doesn't cause non-zero value to be returned.
+>
+> This looks OK. In a perfect world we'd have a test for return values.

+

And distinct codes for warnings and errors... but can't have everything at once...

+

J.

+

> d
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch
+

+ +--bcaec50408e818663b04d32c8672-- -- 2.26.2