From 0d888c527188bcbbda3073055282032112b36048 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 5 Jan 2013 23:50:43 +0200 Subject: [PATCH] Re: [PATCH] emacs: show: make id links respect window --- 81/3ae91ccf72259ccd43c55a80c0d7c1fafc9d45 | 89 +++++++++++++++++++++++ 1 file changed, 89 insertions(+) create mode 100644 81/3ae91ccf72259ccd43c55a80c0d7c1fafc9d45 diff --git a/81/3ae91ccf72259ccd43c55a80c0d7c1fafc9d45 b/81/3ae91ccf72259ccd43c55a80c0d7c1fafc9d45 new file mode 100644 index 000000000..1da075a01 --- /dev/null +++ b/81/3ae91ccf72259ccd43c55a80c0d7c1fafc9d45 @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id CB9A2431FBF + for ; Sat, 5 Jan 2013 13:50:51 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id wix3spaoWZt9 for ; + Sat, 5 Jan 2013 13:50:51 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 35860431FAE + for ; Sat, 5 Jan 2013 13:50:51 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 4FEBC10007D; + Sat, 5 Jan 2013 23:50:43 +0200 (EET) +From: Tomi Ollila +To: David Bremner , + Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: show: make id links respect window +In-Reply-To: <87bodgrh6a.fsf@zancas.localnet> +References: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com> + <87bodjfnt0.fsf@zancas.localnet> <87mwx2jsu0.fsf@qmul.ac.uk> + <87bodgrh6a.fsf@zancas.localnet> +User-Agent: Notmuch/0.14+236~ge6d0259 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 05 Jan 2013 21:50:52 -0000 + +On Wed, Dec 26 2012, David Bremner wrote: + +> Mark Walters writes: +> +>>> I can imagine that people would want/like the "open in other window" +>>> effect of the current code, even if the reason is a bug. +>> +>> That's definitely possible. I generally expect a mouse click to select +>> the window I click and this feels counter intuitive. I think that some +>> people might like an option "open this link in a new window" but I would +>> guess that would like that whether they clicked or pressed RET on the +>> button. +> +> I don't care much either way myself, but before we change notmuch-show +> behaviour (effectively) to accomodate notmuch-pick, I'd like a bit more +> feedback from other people. + +I tested the old behaviour -- split frame to 2 windows, one containing +*scratch* and one *notmuch-hello*. Then I searched for 'obsoletes', +chose last message (id:1356936162-2589-1-git-send-email-amdragon@mit.edu) +moved point to *scratch* buffer and clicked the id: link -- and indeed, +the *scratch* window was replaced. + +I didn't look or test Mark's patch as he stated: +"The lisp is not pretty but seems to work." ;) +... well, not entirely because of that but I trust it opens the message +in window where the clicked link were and keeps point where it used to +be before clicking (in case point was in different window). + +So, personally I'd like to see this fixed but I'm even less qualified +to comment the implementation in the patch. + + +> d + +Tomi -- 2.26.2