From 0b7ba77b1ea1400fa744bd28208f8a46d21f6c4f Mon Sep 17 00:00:00 2001 From: David Bremner Date: Fri, 22 Feb 2013 07:52:18 +2000 Subject: [PATCH] Re: [Patch v2 1/4] nmbug: use dump --format=batch-tag --- 1a/ea249ffedf31db6a6a867d2d3af08ed1b11d52 | 97 +++++++++++++++++++++++ 1 file changed, 97 insertions(+) create mode 100644 1a/ea249ffedf31db6a6a867d2d3af08ed1b11d52 diff --git a/1a/ea249ffedf31db6a6a867d2d3af08ed1b11d52 b/1a/ea249ffedf31db6a6a867d2d3af08ed1b11d52 new file mode 100644 index 000000000..6075505c7 --- /dev/null +++ b/1a/ea249ffedf31db6a6a867d2d3af08ed1b11d52 @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D14B5431FB6 + for ; Thu, 21 Feb 2013 03:52:29 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id F56bPX1Kp4Mu for ; + Thu, 21 Feb 2013 03:52:28 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8F0E3431FAE + for ; Thu, 21 Feb 2013 03:52:28 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1U8UhM-0005E1-Mx; Thu, 21 Feb 2013 07:52:25 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1U8UhG-0001vq-Tf; Thu, 21 Feb 2013 07:52:18 -0400 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [Patch v2 1/4] nmbug: use dump --format=batch-tag +In-Reply-To: +References: <1361399077-7737-1-git-send-email-david@tethera.net> + <1361399077-7737-2-git-send-email-david@tethera.net> + +User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Thu, 21 Feb 2013 07:52:18 -0400 +Message-ID: <87k3q151fx.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 21 Feb 2013 11:52:30 -0000 + +Tomi Ollila writes: + +> +> This patch series looks good to me (as far as I can understand, I did +> not find the "silly bug" in your previous patch...) +> + +Compare : + ++ print $notmuch $A_action.$TAGPREFIX.$pair->{tag}, " -- ", ++ 'id:'.$pair->{id}; + +vs. + ++ print $notmuch $D_action.$TAGPREFIX.$pair->{tag}, ++ 'id:'.$pair->{id}; + +I obviously did not test that version very well. + +> Instead of mentioning that "calls are _not_ passed to shell" here, +> that could be briefly mentioned just before system() calls in the +> script -- and that definitely should not be 'At the moment' feature. + +Sure, the "At the moment" is meant to modify "relies". In the next +patch, we stop relying on this feature of Perl. + +> +> the system() function in perl(1) never pass execution through the +> shell in case the args are list more than one arg: +> + +right. that's what I meant by "is a documented feature of perl's system +function" + +So I think we mean to say the same thing here; but I could I add a +comment in this patch (to delete it in the next). Or maybe reword that +commit message somehow. + +d -- 2.26.2