From 0b4a829d4d63d58b857e0a32d17ca1d7f587115b Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sat, 4 Aug 2012 00:51:46 +0300 Subject: [PATCH] [PATCH 1/7] build: drop the -Wswitch-enum warning --- cd/5b9e77f548ba05b89b717b43559d8ede7f84c4 | 103 ++++++++++++++++++++++ 1 file changed, 103 insertions(+) create mode 100644 cd/5b9e77f548ba05b89b717b43559d8ede7f84c4 diff --git a/cd/5b9e77f548ba05b89b717b43559d8ede7f84c4 b/cd/5b9e77f548ba05b89b717b43559d8ede7f84c4 new file mode 100644 index 000000000..71ada04c4 --- /dev/null +++ b/cd/5b9e77f548ba05b89b717b43559d8ede7f84c4 @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8A93C431FBC + for ; Fri, 3 Aug 2012 14:52:00 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id xDX8Esr9Z0Pi for ; + Fri, 3 Aug 2012 14:52:00 -0700 (PDT) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id AEBEB431FAF + for ; Fri, 3 Aug 2012 14:51:59 -0700 (PDT) +Received: by mail-lpp01m010-f53.google.com with SMTP id u2so681800lag.26 + for ; Fri, 03 Aug 2012 14:51:59 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references + :in-reply-to:references:x-gm-message-state; + bh=Lkr/U+DfYLJmMelD/8ON3yzhjTz3TnHlY29/2rDe5jY=; + b=l/V8cnTUDkl8aOHXCFCl5XnXhckEPATQTQCzBgSVbtCnDmYDdXXxxh5NoxL5U6Y8T9 + tYsoPSmBIfvCw1l/xdocvzyB7lmNol4x8jNcWA+dC8k+wzSTiFF1SgMuuH31RMn9bLnM + iMUjL0ZEaaQYhLJ+54gYG4C7BxjSb3vmVe+B/j6LGMrPFqr0E4hLkVpIOEXQTPURfMSL + GBTVs0n/Qa3ec5e6jBUJ9dv460y6OGhQ/lW1yFtR4GPj/S3jvdwzBi6RU/Y1imJ6vF8K + i4G69WFfMNU8q88ah9mex8w01lLTiMOpDsJQRG4eTVcHii5OCMwEy98EfsEVD/hRpb9U + ZtCw== +Received: by 10.152.125.133 with SMTP id mq5mr2905256lab.12.1344030719312; + Fri, 03 Aug 2012 14:51:59 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id er3sm2251590lbb.16.2012.08.03.14.51.57 + (version=SSLv3 cipher=OTHER); Fri, 03 Aug 2012 14:51:58 -0700 (PDT) +From: Jani Nikula +To: notmuch@notmuchmail.org +Subject: [PATCH 1/7] build: drop the -Wswitch-enum warning +Date: Sat, 4 Aug 2012 00:51:46 +0300 +Message-Id: + <70c91c3a70586075587d7f6971bbe59edeebd77f.1344028781.git.jani@nikula.org> +X-Mailer: git-send-email 1.7.9.5 +In-Reply-To: +References: +In-Reply-To: +References: +X-Gm-Message-State: + ALoCoQnpsbwEb5qc6fRhP7FlJw+AtmBwQntyAVX6bR7wuPg2SUTZtW67yXuM+uKfG2ca4NJ+QJu3 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 03 Aug 2012 21:52:01 -0000 + +-Wswitch-enum is a bit awkward if a switch statement is intended to +handle just some of the named codes of an enumeration especially, and +leave the rest to the default label. + +We already have -Wall, which enables -Wswitch by default, and per GCC +documentation, "The only difference between -Wswitch and this option +[-Wswitch-enum] is that this option gives a warning about an omitted +enumeration code even if there is a default label." + +Drop -Wswitch-enum to not force listing all named codes of +enumerations in switch statements that have a default label. + +--- + +This will be useful in the next patch. +--- + configure | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/configure b/configure +index dc0dba4..4433f42 100755 +--- a/configure ++++ b/configure +@@ -528,7 +528,7 @@ fi + + WARN_CXXFLAGS="" + printf "Checking for available C++ compiler warning flags... " +-for flag in -Wall -Wextra -Wwrite-strings -Wswitch-enum; do ++for flag in -Wall -Wextra -Wwrite-strings; do + if ${CC} $flag -o minimal minimal.c > /dev/null 2>&1 + then + WARN_CXXFLAGS="${WARN_CXXFLAGS}${WARN_CXXFLAGS:+ }${flag}" +-- +1.7.9.5 + -- 2.26.2