From 0a2d8b08637ebaf0e2109fe48386d755bb17b528 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 17 Feb 2013 10:11:15 +2000 Subject: [PATCH] Re: [PATCH 1/2] test/test-lib.sh: use $test_subtest_name in all tests --- ed/66bc687a97bc066a6827a2e2b8a0ca3806f128 | 71 +++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 ed/66bc687a97bc066a6827a2e2b8a0ca3806f128 diff --git a/ed/66bc687a97bc066a6827a2e2b8a0ca3806f128 b/ed/66bc687a97bc066a6827a2e2b8a0ca3806f128 new file mode 100644 index 000000000..68c07e0c5 --- /dev/null +++ b/ed/66bc687a97bc066a6827a2e2b8a0ca3806f128 @@ -0,0 +1,71 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A263F431FBC + for ; Sat, 16 Feb 2013 06:11:30 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id z0t5OxTPWM2q for ; + Sat, 16 Feb 2013 06:11:29 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id EFC5F431FAF + for ; Sat, 16 Feb 2013 06:11:28 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1U6iU5-00060D-QU; Sat, 16 Feb 2013 10:11:25 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1U6iU0-00057M-1q; Sat, 16 Feb 2013 10:11:16 -0400 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] test/test-lib.sh: use $test_subtest_name in all tests +In-Reply-To: <1358737306-21744-1-git-send-email-tomi.ollila@iki.fi> +References: + <1358737306-21744-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Sat, 16 Feb 2013 10:11:15 -0400 +Message-ID: <874nhc73i4.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 16 Feb 2013 14:11:30 -0000 + +Tomi Ollila writes: + +> Set the variable '$test_subtest_name' in all functions which starts +> a new test and use that variable in all functions that output +> test results. +> +> Additionally output the latest '$test_subtest_name' in case of +> abnormal exit, to avoid confusion. + +The series looks OK to me. The first patch is a bit noisy, but I guess +it results in simpler code. + +d -- 2.26.2